Bug 237085

Summary: Share more code between service and shared workers for context connection establishment
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, kkinnunen, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236874
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Chris Dumez
Reported 2022-02-23 07:46:26 PST
Share more code between service and shared workers for context connection establishment.
Attachments
Patch (44.35 KB, patch)
2022-02-23 08:02 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (51.29 KB, patch)
2022-02-23 08:56 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (52.68 KB, patch)
2022-02-23 08:59 PST, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (52.55 KB, patch)
2022-02-23 09:50 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-02-23 08:02:32 PST
Created attachment 452981 [details] Patch
youenn fablet
Comment 2 2022-02-23 08:24:22 PST
Comment on attachment 452981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452981&action=review > Source/WebKit/UIProcess/Network/NetworkProcessProxy.messages.in:59 > + EstablishRemoteWorkerContextConnectionToNetworkProcess(enum:uint32_t WebKit::RemoteWorkerType workerType, WebCore::RegistrableDomain registrableDomain, std::optional<WebCore::ProcessIdentifier> requestingProcessIdentifier, std::optional<WebCore::ScriptExecutionContextIdentifier> serviceWorkerPageIdentifier, PAL::SessionID sessionID) -> () Async Why is it a uint32_t, should it not be either a bool or maybe a uint8_t? > Source/WebKit/UIProcess/WebProcessPool.cpp:558 > + bool shouldUseSeparateRemoteWorkerProcess = workerType == RemoteWorkerType::ServiceWorker && s_useSeparateServiceWorkerProcess; We might want to use s_useSeparateServiceWorkerProcess for shared workers as well for testing things like crash of shared worker process.
Chris Dumez
Comment 3 2022-02-23 08:56:04 PST
Created attachment 452985 [details] Patch
Chris Dumez
Comment 4 2022-02-23 08:59:12 PST
Created attachment 452986 [details] Patch
Chris Dumez
Comment 5 2022-02-23 09:50:25 PST
Created attachment 452994 [details] Patch
EWS
Comment 6 2022-02-23 12:13:36 PST
Committed r290387 (247702@main): <https://commits.webkit.org/247702@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452994 [details].
Radar WebKit Bug Importer
Comment 7 2022-02-23 12:14:16 PST
<rdar://problem/89370920>
Note You need to log in before you can comment on or make changes to this bug.