Bug 23700 – Upstream local changes to GlyphPageTreeNodeChromiumWin.cpp

• Component: Platform
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

The change in fillBMPGlyphs is due to unforking of SimpleFontData and the change in fillNonBMPGlyphs is to address http://code.google.com/p/chromium/issues/detail?id=6303

[Dimitri Glazkov (Google)]

Created attachment 27274 [details]
Upstream local changes to due to unforking, bug fixes.

 WebCore/ChangeLog                                  |   11 +++++++++++
 .../chromium/GlyphPageTreeNodeChromiumWin.cpp      |   15 +++------------
 2 files changed, 14 insertions(+), 12 deletions(-)

[Eric Seidel (no email)]

Comment on attachment 27274 [details]
Upstream local changes to due to unforking, bug fixes.

It would be useful to know what these changes are for?  Otherwise the change looks fine... if you update the ChangeLog to point to the chromium bugs fixed (or at least the commits) that would be helpful.

[Darin Adler]

Comment on attachment 27274 [details]
Upstream local changes to due to unforking, bug fixes.

rs=me

[Jungshik Shin]

Dimitiri, this patch overlaps with what I put up for bug 23602. setDisableFontFallback bit relies on that patch. Can you remove that part from the patch here or merge two patches (for bug 23602 and this bug)? 

Eric, can you review the patch for bug 23602? 

[Dimitri Glazkov (Google)]

Oops -- I will remove your modification, Jungshik. Didn't mean to step on your toes.

[Dimitri Glazkov (Google)]

Landed as http://trac.webkit.org/changeset/40619