| Summary: | Upstream local changes to GlyphPageTreeNodeChromiumWin.cpp | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Component: | Platform | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | jshin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Dimitri Glazkov (Google)
2009-02-02 20:38:03 PST
Created attachment 27274 [details]
Upstream local changes to due to unforking, bug fixes.
WebCore/ChangeLog | 11 +++++++++++
.../chromium/GlyphPageTreeNodeChromiumWin.cpp | 15 +++------------
2 files changed, 14 insertions(+), 12 deletions(-)
Comment on attachment 27274 [details]
Upstream local changes to due to unforking, bug fixes.
It would be useful to know what these changes are for? Otherwise the change looks fine... if you update the ChangeLog to point to the chromium bugs fixed (or at least the commits) that would be helpful.
Comment on attachment 27274 [details]
Upstream local changes to due to unforking, bug fixes.
rs=me
Dimitiri, this patch overlaps with what I put up for bug 23602. setDisableFontFallback bit relies on that patch. Can you remove that part from the patch here or merge two patches (for bug 23602 and this bug)? Eric, can you review the patch for bug 23602? Oops -- I will remove your modification, Jungshik. Didn't mean to step on your toes. Landed as http://trac.webkit.org/changeset/40619 |