Bug 236705

Summary: [EWS][GTK] Send only one e-mail with all the list of flakies
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, aperez, bugs-noreply, don.olmstead, dpino, jbedard, lmoura, psaavedra, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=231999
https://bugs.webkit.org/show_bug.cgi?id=236654
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Carlos Alberto Lopez Perez
Reported 2022-02-16 07:54:02 PST
The current EWS for GTK layout tests is sending one e-mail per flaky detected (one per test). This seems is too much and we are spamming ourselves. Change this to only send one e-mail per run with the list of all flakies detected in the body of the e-mail
Attachments
Patch (6.89 KB, patch)
2022-02-16 08:01 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (38.93 KB, patch)
2022-02-16 10:53 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (43.50 KB, patch)
2022-02-16 12:00 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Patch (40.99 KB, patch)
2022-02-16 12:43 PST, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2022-02-16 08:01:03 PST
Created attachment 452198 [details] Patch
Aakash Jain
Comment 2 2022-02-16 10:00:19 PST
Ryan what do you think about this?
Carlos Alberto Lopez Perez
Comment 3 2022-02-16 10:48:04 PST
I'm going to upload a new version that adds unit tests for this, to check that the mail messages are created with the expected content
Carlos Alberto Lopez Perez
Comment 4 2022-02-16 10:49:29 PST
(In reply to Aakash Jain from comment #2) > Ryan what do you think about this? Note that this will only affect the GTK layout tests on the EWS. The other EWS for layout test (Apple ones) still keep sending one e-mail per flaky test
Carlos Alberto Lopez Perez
Comment 5 2022-02-16 10:53:17 PST
Created attachment 452213 [details] Patch
Ryan Haddad
Comment 6 2022-02-16 11:34:18 PST
(In reply to Carlos Alberto Lopez Perez from comment #4) > (In reply to Aakash Jain from comment #2) > > Ryan what do you think about this? > > Note that this will only affect the GTK layout tests on the EWS. > > The other EWS for layout test (Apple ones) still keep sending one e-mail per > flaky test Got it, thank you for clarifying!
Carlos Alberto Lopez Perez
Comment 7 2022-02-16 12:00:42 PST
Created attachment 452226 [details] Patch trying EWS
Carlos Alberto Lopez Perez
Comment 8 2022-02-16 12:43:31 PST
Created attachment 452230 [details] Patch trying EWS again, includes also the fixes commented at https://bugs.webkit.org/show_bug.cgi?id=236654#c4
Carlos Alberto Lopez Perez
Comment 9 2022-02-16 12:53:09 PST
Committed r289947 (247349@trunk): <https://commits.webkit.org/247349@trunk>
Radar WebKit Bug Importer
Comment 10 2022-02-16 12:54:19 PST
<rdar://problem/89043231>
Note You need to log in before you can comment on or make changes to this bug.