Bug 236654
| Summary: | [EWS] Support PRs when sending layout test failure emails | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | clopez, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=234847 https://bugs.webkit.org/show_bug.cgi?id=235926 https://bugs.webkit.org/show_bug.cgi?id=236705 |
||
Jonathan Bedard
AnalyzeLayoutTestsResults emails change authors when their change fails EWS. We should support pull-requests in this step.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/88974170>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/147
Jonathan Bedard
Landed 247326@main (r289888)
Carlos Alberto Lopez Perez
(In reply to Jonathan Bedard from comment #3)
> Landed 247326@main (r289888)
there are a few issues with this patch:
a few _addToLog() calls miss the two parameters needed and there is one variable undefined.
I detected this meanwhile working on bug 236705 which adds unit tests to test the send_email() calls
This would be the fix: http://sprunge.us/BNhsG4
I can include it as part of bug 236705
Carlos Alberto Lopez Perez
(In reply to Carlos Alberto Lopez Perez from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > Landed 247326@main (r289888)
>
> there are a few issues with this patch:
>
> a few _addToLog() calls miss the two parameters needed and there is one
> variable undefined.
>
> I detected this meanwhile working on bug 236705 which adds unit tests to
> test the send_email() calls
>
> This would be the fix: http://sprunge.us/BNhsG4
>
> I can include it as part of bug 236705
I landed 289947 that includes also those fixes.
Now the unit tests exercise the code for the send_email_* functions so this should be easier to detect in the future
Carlos Alberto Lopez Perez
(In reply to Carlos Alberto Lopez Perez from comment #5)
> (In reply to Carlos Alberto Lopez Perez from comment #4)
> > (In reply to Jonathan Bedard from comment #3)
> > > Landed 247326@main (r289888)
> >
> > there are a few issues with this patch:
> >
> > a few _addToLog() calls miss the two parameters needed and there is one
> > variable undefined.
> >
> > I detected this meanwhile working on bug 236705 which adds unit tests to
> > test the send_email() calls
> >
> > This would be the fix: http://sprunge.us/BNhsG4
> >
> > I can include it as part of bug 236705
>
> I landed 289947 that includes also those fixes.
>
> Now the unit tests exercise the code for the send_email_* functions so this
> should be easier to detect in the future
r289947