Bug 236481

Summary: [IFC][Integration] Enable non-paginated vertical-lr writing mode
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jonlee, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=170176
https://bugs.webkit.org/show_bug.cgi?id=209080
https://bugs.webkit.org/show_bug.cgi?id=214291
https://bugs.webkit.org/show_bug.cgi?id=237501
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description zalan 2022-02-10 19:55:58 PST 
ssia
Comment 1 zalan 2022-02-10 21:12:40 PST 
Created attachment 451638 [details]
Patch
Comment 2 Antti Koivisto 2022-02-10 21:14:15 PST 
Comment on attachment 451638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451638&action=review

> Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-585
> -    if (!flow.isHorizontalWritingMode())
> -        SET_REASON_AND_RETURN_IF_NEEDED(FlowHasHorizonalWritingMode, reasons, includeReasons);

Finally!
Comment 3 zalan 2022-02-13 10:26:39 PST 
Created attachment 451823 [details]
Patch
Comment 4 zalan 2022-02-13 11:34:46 PST 
Created attachment 451830 [details]
Patch
Comment 5 zalan 2022-02-13 20:37:09 PST 
Created attachment 451855 [details]
Patch
Comment 6 zalan 2022-02-15 20:42:07 PST 
Created attachment 452132 [details]
Patch
Comment 7 zalan 2022-02-16 21:30:31 PST 
Created attachment 452310 [details]
Patch
Comment 8 Radar WebKit Bug Importer 2022-02-17 19:56:18 PST 
<rdar://problem/89123721>
Comment 9 zalan 2022-02-18 05:46:30 PST 
Created attachment 452513 [details]
Patch
Comment 10 zalan 2022-02-18 07:32:24 PST 
Created attachment 452519 [details]
Patch
Comment 11 zalan 2022-02-18 16:37:47 PST 
Created attachment 452604 [details]
Patch
Comment 12 zalan 2022-02-18 16:38:45 PST 
Created attachment 452605 [details]
Patch
Comment 13 zalan 2022-02-18 21:19:14 PST 
Created attachment 452623 [details]
Patch
Comment 14 zalan 2022-02-19 10:23:10 PST 
Created attachment 452645 [details]
Patch
Comment 15 zalan 2022-02-19 21:27:01 PST 
Created attachment 452677 [details]
Patch
Comment 16 zalan 2022-02-20 07:12:58 PST 
Created attachment 452694 [details]
Patch
Comment 17 EWS 2022-02-20 09:54:56 PST 
Committed r290229 (247554@main): <https://commits.webkit.org/247554@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 452694 [details].
Comment 18 Jon Lee 2022-02-20 15:51:40 PST 
This fixed a number of tests. Related bugs, and removed test expectations in r290235.