Bug 236481

Summary:

[IFC][Integration] Enable non-paginated vertical-lr writing mode

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, jonlee, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=170176
https://bugs.webkit.org/show_bug.cgi?id=209080
https://bugs.webkit.org/show_bug.cgi?id=214291
https://bugs.webkit.org/show_bug.cgi?id=237501

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

zalan

Reported 2022-02-10 19:55:58 PST

ssia

Attachments
Patch (5.13 KB, patch) 2022-02-10 21:12 PST, zalan	no flags	Details Formatted Diff Diff
Patch (30.76 KB, patch) 2022-02-13 10:26 PST, zalan	no flags	Details Formatted Diff Diff
Patch (30.82 KB, patch) 2022-02-13 11:34 PST, zalan	no flags	Details Formatted Diff Diff
Patch (41.63 KB, patch) 2022-02-13 20:37 PST, zalan	no flags	Details Formatted Diff Diff
Patch (59.16 KB, patch) 2022-02-15 20:42 PST, zalan	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (45.80 KB, patch) 2022-02-16 21:30 PST, zalan	no flags	Details Formatted Diff Diff
Patch (62.97 KB, patch) 2022-02-18 05:46 PST, zalan	no flags	Details Formatted Diff Diff
Patch (62.97 KB, patch) 2022-02-18 07:32 PST, zalan	no flags	Details Formatted Diff Diff
Patch (45.26 KB, patch) 2022-02-18 16:37 PST, zalan	no flags	Details Formatted Diff Diff
Patch (62.17 KB, patch) 2022-02-18 16:38 PST, zalan	no flags	Details Formatted Diff Diff
Patch (62.52 KB, patch) 2022-02-18 21:19 PST, zalan	no flags	Details Formatted Diff Diff
Patch (67.61 KB, patch) 2022-02-19 10:23 PST, zalan	no flags	Details Formatted Diff Diff
Patch (139.48 KB, patch) 2022-02-19 21:27 PST, zalan	no flags	Details Formatted Diff Diff
Patch (146.44 KB, patch) 2022-02-20 07:12 PST, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (13) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2022-02-10 21:12:40 PST

Created attachment 451638 [details] Patch

Antti Koivisto

Comment 2 2022-02-10 21:14:15 PST

Comment on attachment 451638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451638&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-585 > - if (!flow.isHorizontalWritingMode()) > - SET_REASON_AND_RETURN_IF_NEEDED(FlowHasHorizonalWritingMode, reasons, includeReasons); Finally!

zalan

Comment 3 2022-02-13 10:26:39 PST

Created attachment 451823 [details] Patch

zalan

Comment 4 2022-02-13 11:34:46 PST

Created attachment 451830 [details] Patch

zalan

Comment 5 2022-02-13 20:37:09 PST

Created attachment 451855 [details] Patch

zalan

Comment 6 2022-02-15 20:42:07 PST

Created attachment 452132 [details] Patch