Bug 236338

Summary: Account for the sub grid's margin/border/padding on descendant items
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: CSSAssignee: Matt Woodrow <mattwoodrow>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, clopez, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jean-yves.avenard, jfernandez, koivisto, kondapallykalyan, macpherson, menard, pdr, rego, svillar, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/32586
Bug Depends on: 236337    
Bug Blocks: 202115    
Attachments:
Description Flags
Patch
none
Patch for EWS
none
Patch
dino: review+
Patch none

Matt Woodrow
Reported 2022-02-08 15:46:18 PST
When children of a sub grid are included into an outer grid's track sizing algorthim, we need to account for the margin/border/padding of the subgrid element itself as part of their intrinsic size. https://drafts.csswg.org/css-grid-2/#subgrid-item-contribution
Attachments
Patch (33.83 KB, patch)
2022-02-14 19:24 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch for EWS (139.74 KB, patch)
2022-02-14 19:25 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (34.04 KB, patch)
2022-02-15 13:09 PST, Matt Woodrow 		dino: review+
DetailsFormatted DiffDiff
Patch (33.33 KB, patch)
2022-02-17 12:19 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Woodrow
Comment 1 2022-02-14 19:24:34 PST
Created attachment 451979 [details] Patch
Matt Woodrow
Comment 2 2022-02-14 19:25:14 PST
Created attachment 451980 [details] Patch for EWS
EWS Watchlist
Comment 3 2022-02-15 11:30:14 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Matt Woodrow
Comment 4 2022-02-15 13:09:29 PST
Created attachment 452078 [details] Patch
Radar WebKit Bug Importer
Comment 5 2022-02-15 15:47:17 PST
<rdar://problem/88991969>
Dean Jackson
Comment 6 2022-02-15 21:51:03 PST
Comment on attachment 452078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452078&action=review > LayoutTests/imported/w3c/ChangeLog:12 > + * web-platform-tests/css/css-grid/subgrid/abs-pos-002-expected.html: > + * web-platform-tests/css/css-grid/subgrid/abs-pos-003-expected.html: > + * web-platform-tests/css/css-grid/subgrid/line-names-008.html: > + * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001.html: > + * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002.html: What's the plan for getting these changes merged back?
Matt Woodrow
Comment 7 2022-02-16 14:36:16 PST
(In reply to Dean Jackson from comment #6) > Comment on attachment 452078 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452078&action=review > > > LayoutTests/imported/w3c/ChangeLog:12 > > + * web-platform-tests/css/css-grid/subgrid/abs-pos-002-expected.html: > > + * web-platform-tests/css/css-grid/subgrid/abs-pos-003-expected.html: > > + * web-platform-tests/css/css-grid/subgrid/line-names-008.html: > > + * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001.html: > > + * web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002.html: > > What's the plan for getting these changes merged back? For better or for worse, I figured out these test changes weeks before I had any sort of sanely reviewable WebKit changes, so I uploaded most of them directly to WPT. I've linked this bug with the WPT pull request for line-names-008.html, but there's also two other WPT pull requests covering these changes. https://github.com/web-platform-tests/wpt/pull/32611 https://github.com/web-platform-tests/wpt/pull/32585 I'm not sure if I can link multiple WPT pull requests to a single bug, and I'm scared to risk trying and breaking things. Hopefully those extra two will get approved and pushed.
Matt Woodrow
Comment 8 2022-02-17 12:19:06 PST
Created attachment 452407 [details] Patch
EWS
Comment 9 2022-02-17 16:55:56 PST
Committed r290096 (247446@main): <https://commits.webkit.org/247446@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452407 [details].
Note You need to log in before you can comment on or make changes to this bug.