Bug 236337

Summary: Include sub grid items in the track sizing algorithm of the outer grid
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: CSSAssignee: Matt Woodrow <mattwoodrow>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, clopez, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jfernandez, koivisto, kondapallykalyan, macpherson, menard, pdr, rego, svillar, tsavell, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 236336    
Bug Blocks: 202115, 236338    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for EWS
none
Patch
none
Patch
none
Patch none

Matt Woodrow
Reported 2022-02-08 15:43:32 PST
When computing the track sizing of a grid with sub grid items, we should recursively introspect subgrid items and include their children in the sizing computations.
Attachments
Patch (25.33 KB, patch)
2022-02-08 16:17 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (25.46 KB, patch)
2022-02-14 17:38 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch for EWS (116.04 KB, patch)
2022-02-14 17:39 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (21.95 KB, patch)
2022-02-15 10:54 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (21.99 KB, patch)
2022-02-15 12:53 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Patch (22.76 KB, patch)
2022-02-17 11:48 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Matt Woodrow
Comment 1 2022-02-08 16:17:43 PST
Created attachment 451321 [details] Patch
Matt Woodrow
Comment 2 2022-02-14 17:38:12 PST
Created attachment 451970 [details] Patch
Matt Woodrow
Comment 3 2022-02-14 17:39:05 PST
Created attachment 451971 [details] Patch for EWS
EWS Watchlist
Comment 4 2022-02-14 17:55:02 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Matt Woodrow
Comment 5 2022-02-15 10:54:45 PST
Created attachment 452056 [details] Patch
Matt Woodrow
Comment 6 2022-02-15 12:53:58 PST
Created attachment 452075 [details] Patch
Radar WebKit Bug Importer
Comment 7 2022-02-15 15:44:20 PST
<rdar://problem/88991771>
Matt Woodrow
Comment 8 2022-02-17 11:48:13 PST
Created attachment 452398 [details] Patch
Truitt Savell
Comment 9 2022-02-17 14:54:03 PST
Comment on attachment 452398 [details] Patch Clearing flags on attachment: 452398 Committed r290077 (247434@trunk): <https://commits.webkit.org/247434@trunk>
Note You need to log in before you can comment on or make changes to this bug.