Bug 236165

Summary: Update MediaStreamTrack understanding of source type
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Eric Carlson 2022-02-04 16:24:26 PST 
Bug 235838 changed RealtimeMediaSource::type() to have more than 'audio' and 'video', but didn't update MediaStream/MediaStreamTrack accordingly.
Comment 1 Radar WebKit Bug Importer 2022-02-04 16:24:37 PST 
<rdar://problem/88513632>
Comment 2 Eric Carlson 2022-02-04 16:40:21 PST 
Created attachment 450949 [details]
Patch
Comment 3 Jer Noble 2022-02-04 16:42:43 PST 
Comment on attachment 450949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450949&action=review

> Source/WebCore/ChangeLog:11
> +        wasn't updated to account for the. Instead of checking a source's type, use the new

"wasn't updated to account for the." 

I'm dying with anticipation!
Comment 4 Eric Carlson 2022-02-04 16:52:55 PST 
Created attachment 450953 [details]
Patch
Comment 5 Eric Carlson 2022-02-04 17:36:43 PST 
Created attachment 450957 [details]
Patch
Comment 6 Eric Carlson 2022-02-04 18:40:03 PST 
Created attachment 450960 [details]
Patch
Comment 7 EWS 2022-02-04 21:34:07 PST 
Committed r289149 (246845@main): <https://commits.webkit.org/246845@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450960 [details].