Bug 236165

Summary: Update MediaStreamTrack understanding of source type
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Eric Carlson
Reported 2022-02-04 16:24:26 PST
Bug 235838 changed RealtimeMediaSource::type() to have more than 'audio' and 'video', but didn't update MediaStream/MediaStreamTrack accordingly.
Attachments
Patch (14.25 KB, patch)
2022-02-04 16:40 PST, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.24 KB, patch)
2022-02-04 16:52 PST, Eric Carlson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (14.24 KB, patch)
2022-02-04 17:36 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (15.56 KB, patch)
2022-02-04 18:40 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-04 16:24:37 PST
<rdar://problem/88513632>
Eric Carlson
Comment 2 2022-02-04 16:40:21 PST
Created attachment 450949 [details] Patch
Jer Noble
Comment 3 2022-02-04 16:42:43 PST
Comment on attachment 450949 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450949&action=review > Source/WebCore/ChangeLog:11 > + wasn't updated to account for the. Instead of checking a source's type, use the new "wasn't updated to account for the." I'm dying with anticipation!
Eric Carlson
Comment 4 2022-02-04 16:52:55 PST
Created attachment 450953 [details] Patch
Eric Carlson
Comment 5 2022-02-04 17:36:43 PST
Created attachment 450957 [details] Patch
Eric Carlson
Comment 6 2022-02-04 18:40:03 PST
Created attachment 450960 [details] Patch
EWS
Comment 7 2022-02-04 21:34:07 PST
Committed r289149 (246845@main): <https://commits.webkit.org/246845@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450960 [details].
Note You need to log in before you can comment on or make changes to this bug.