Bug 236100

Summary: Add PageClient plumbing for video frame extraction
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, bdakin, eric.carlson, ews-watchlist, glenn, jer.noble, megan_gardner, philipj, sergio, thorton
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 236083, 236094    
Bug Blocks:    
Attachments:
Description Flags
WIP
none
Rebase on trunk
eric.carlson: review+, ews-feeder: commit-queue-
For landing none

Wenson Hsieh
Reported 2022-02-03 13:11:37 PST Comment hidden (obsolete)
Attachments
WIP (15.69 KB, patch)
2022-02-03 13:53 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rebase on trunk (15.63 KB, patch)
2022-02-07 09:27 PST, Wenson Hsieh 		eric.carlson: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
For landing (15.73 KB, patch)
2022-02-07 10:13 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-02-03 13:12:33 PST
rdar://86237608
Wenson Hsieh
Comment 2 2022-02-03 13:53:32 PST Comment hidden (obsolete)
Wenson Hsieh
Comment 3 2022-02-07 09:27:54 PST
Created attachment 451116 [details] Rebase on trunk
Eric Carlson
Comment 4 2022-02-07 09:43:20 PST
Comment on attachment 451116 [details] Rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=451116&action=review > Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:511 > + if (RetainPtr controller = protectedThis->m_videoFullscreenManager->playerViewController(identifier)) You null-checked m_videoFullscreenManager before the completion handler, but is it guaranteed to still be valid here?
Wenson Hsieh
Comment 5 2022-02-07 10:03:37 PST
Comment on attachment 451116 [details] Rebase on trunk View in context: https://bugs.webkit.org/attachment.cgi?id=451116&action=review Thanks for the review! >> Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:511 >> + if (RetainPtr controller = protectedThis->m_videoFullscreenManager->playerViewController(identifier)) > > You null-checked m_videoFullscreenManager before the completion handler, but is it guaranteed to still be valid here? Great catch! I don't see any (obvious) reason why it's still guaranteed to be valid here, so I'll add a null check for `protectedThis->m_videoFullscreenManager` as well.
Wenson Hsieh
Comment 6 2022-02-07 10:13:03 PST
Created attachment 451122 [details] For landing
EWS
Comment 7 2022-02-07 12:20:00 PST
Committed r289237 (246921@main): <https://commits.webkit.org/246921@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451122 [details].
Note You need to log in before you can comment on or make changes to this bug.