Bug 236083 - Add plumbing to inform WebPageProxy when videos play, pause, seek, and enter or exit fullscreen
Summary: Add plumbing to inform WebPageProxy when videos play, pause, seek, and enter ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks: 236100
  Show dependency tree / graph
 
Reported: 2022-02-03 08:34 PST by Wenson Hsieh
Modified: 2022-02-03 17:09 PST (History)
10 users (show)

See Also:

Attachments
For EWS (24.86 KB, patch)
2022-02-03 08:58 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Rebase on trunk (24.07 KB, patch)
2022-02-03 09:41 PST, Wenson Hsieh 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix tvOS build (24.62 KB, patch)
2022-02-03 10:41 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix Win/GTK/WPE builds (24.34 KB, patch)
2022-02-03 13:42 PST, Wenson Hsieh 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (24.34 KB, patch)
2022-02-03 16:18 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2022-02-03 08:34:36 PST 
.
Comment 1 Wenson Hsieh 2022-02-03 08:58:37 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2022-02-03 09:41:50 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2022-02-03 10:41:55 PST Comment hidden (obsolete)
Comment 4 Wenson Hsieh 2022-02-03 13:42:46 PST 
Created attachment 450813 [details]
Fix Win/GTK/WPE builds
Comment 5 Eric Carlson 2022-02-03 14:58:08 PST 
Comment on attachment 450813 [details]
Fix Win/GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=450813&action=review

> Source/WebKit/ChangeLog:9
> +        PlaybackSessionManagerProxy; in future patches, this will be used to detect when a fullscreen video has been

s/this/these/
Comment 6 Wenson Hsieh 2022-02-03 16:10:32 PST 
Comment on attachment 450813 [details]
Fix Win/GTK/WPE builds

View in context: https://bugs.webkit.org/attachment.cgi?id=450813&action=review

Thanks for the review!

>> Source/WebKit/ChangeLog:9
>> +        PlaybackSessionManagerProxy; in future patches, this will be used to detect when a fullscreen video has been
> 
> s/this/these/

Fixed the typo.
Comment 7 Wenson Hsieh 2022-02-03 16:18:43 PST 
Created attachment 450835 [details]
Patch for landing
Comment 8 EWS 2022-02-03 17:08:05 PST 
Committed r289090 (246790@main): <https://commits.webkit.org/246790@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450835 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-03 17:09:18 PST 
<rdar://problem/88464056>