WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
236083
Add plumbing to inform WebPageProxy when videos play, pause, seek, and enter or exit fullscreen
https://bugs.webkit.org/show_bug.cgi?id=236083
Summary
Add plumbing to inform WebPageProxy when videos play, pause, seek, and enter ...
Wenson Hsieh
Reported
2022-02-03 08:34:36 PST
.
Attachments
For EWS
(24.86 KB, patch)
2022-02-03 08:58 PST
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
Rebase on trunk
(24.07 KB, patch)
2022-02-03 09:41 PST
,
Wenson Hsieh
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Fix tvOS build
(24.62 KB, patch)
2022-02-03 10:41 PST
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
Fix Win/GTK/WPE builds
(24.34 KB, patch)
2022-02-03 13:42 PST
,
Wenson Hsieh
eric.carlson
: review+
Details
Formatted Diff
Diff
Patch for landing
(24.34 KB, patch)
2022-02-03 16:18 PST
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2022-02-03 08:58:37 PST
Comment hidden (obsolete)
Created
attachment 450776
[details]
For EWS
Wenson Hsieh
Comment 2
2022-02-03 09:41:50 PST
Comment hidden (obsolete)
Created
attachment 450786
[details]
Rebase on trunk
Wenson Hsieh
Comment 3
2022-02-03 10:41:55 PST
Comment hidden (obsolete)
Created
attachment 450793
[details]
Fix tvOS build
Wenson Hsieh
Comment 4
2022-02-03 13:42:46 PST
Created
attachment 450813
[details]
Fix Win/GTK/WPE builds
Eric Carlson
Comment 5
2022-02-03 14:58:08 PST
Comment on
attachment 450813
[details]
Fix Win/GTK/WPE builds View in context:
https://bugs.webkit.org/attachment.cgi?id=450813&action=review
> Source/WebKit/ChangeLog:9 > + PlaybackSessionManagerProxy; in future patches, this will be used to detect when a fullscreen video has been
s/this/these/
Wenson Hsieh
Comment 6
2022-02-03 16:10:32 PST
Comment on
attachment 450813
[details]
Fix Win/GTK/WPE builds View in context:
https://bugs.webkit.org/attachment.cgi?id=450813&action=review
Thanks for the review!
>> Source/WebKit/ChangeLog:9 >> + PlaybackSessionManagerProxy; in future patches, this will be used to detect when a fullscreen video has been > > s/this/these/
Fixed the typo.
Wenson Hsieh
Comment 7
2022-02-03 16:18:43 PST
Created
attachment 450835
[details]
Patch for landing
EWS
Comment 8
2022-02-03 17:08:05 PST
Committed
r289090
(
246790@main
): <
https://commits.webkit.org/246790@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 450835
[details]
.
Radar WebKit Bug Importer
Comment 9
2022-02-03 17:09:18 PST
<
rdar://problem/88464056
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug