Bug 235857

Summary:

Add PushService

Product:

WebKit

Reporter:

Ben Nham <nham>

Component:

New Bugs

Assignee:

Ben Nham <nham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, cdumez, commit-queue, dvpdiner2, hypertree, katherine_cheney, nham, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

234194, 235855, 235856, 236264

Bug Blocks:

Attachments:

Description	Flags
Patch	none
rebase	none
rebase	none
add tests for different payload types	none
rebase	ews-feeder: commit-queue-
rebase	none
Patch for landing	none
Patch for landing	none
Patch for landing	none
Patch for landing	none

Ben Nham

Reported 2022-01-28 23:46:24 PST

Add PushService

Attachments
Patch (86.22 KB, patch) 2022-01-28 23:48 PST, Ben Nham	no flags	Details Formatted Diff Diff
rebase (86.22 KB, patch) 2022-01-30 22:52 PST, Ben Nham	no flags	Details Formatted Diff Diff
rebase (86.25 KB, patch) 2022-01-31 13:49 PST, Ben Nham	no flags	Details Formatted Diff Diff
add tests for different payload types (90.83 KB, patch) 2022-02-01 14:21 PST, Ben Nham	no flags	Details Formatted Diff Diff
rebase (90.97 KB, patch) 2022-02-05 15:31 PST, Ben Nham	ews-feeder: commit-queue-	Details Formatted Diff Diff
rebase (91.00 KB, patch) 2022-02-05 16:00 PST, Ben Nham	no flags	Details Formatted Diff Diff
Patch for landing (91.00 KB, patch) 2022-02-07 11:56 PST, Ben Nham	no flags	Details Formatted Diff Diff
Patch for landing (91.00 KB, patch) 2022-02-07 12:05 PST, Ben Nham	no flags	Details Formatted Diff Diff
Patch for landing (91.03 KB, patch) 2022-02-07 13:19 PST, Ben Nham	no flags	Details Formatted Diff Diff
Patch for landing (91.16 KB, patch) 2022-02-07 17:22 PST, Ben Nham	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Ben Nham

Comment 1 2022-01-28 23:48:28 PST

Created attachment 450321 [details] Patch

Radar WebKit Bug Importer

Comment 2 2022-01-28 23:50:18 PST

<rdar://problem/88219139>

Ben Nham

Comment 3 2022-01-30 22:52:26 PST

Created attachment 450382 [details] rebase

Ben Nham

Comment 4 2022-01-31 13:49:31 PST

Created attachment 450455 [details] rebase

Ben Nham

Comment 5 2022-02-01 14:21:47 PST

Created attachment 450567 [details] add tests for different payload types

Ben Nham

Comment 6 2022-02-05 15:31:13 PST

Created attachment 451003 [details] rebase

Ben Nham

Comment 7 2022-02-05 16:00:44 PST

Created attachment 451008 [details] rebase

Brady Eidson

Comment 8 2022-02-07 11:05:03 PST

Comment on attachment 451008 [details] rebase View in context: https://bugs.webkit.org/attachment.cgi?id=451008&action=review > Source/WebKit/Shared/Cocoa/WebPushMessageCocoa.mm:43 > + BOOL isNull = pushData == [NSNull null]; You can find example of both in our code base, but it's much more proper to do: [pushData isEqual:[NSNull null]];

Ben Nham

Comment 9 2022-02-07 11:56:41 PST

Created attachment 451131 [details] Patch for landing

EWS

Comment 10 2022-02-07 11:57:45 PST

ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.

Ben Nham

Comment 11 2022-02-07 12:05:55 PST

Created attachment 451134 [details] Patch for landing

EWS

Comment 12 2022-02-07 13:12:03 PST

Patch 451134 does not build

Ben Nham

Comment 13 2022-02-07 13:19:58 PST

Created attachment 451144 [details] Patch for landing

EWS

Comment 14 2022-02-07 14:08:21 PST

Committed r289239 (246923@main): <https://commits.webkit.org/246923@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451144 [details].

WebKit Commit Bot

Comment 15 2022-02-07 15:10:56 PST

Re-opened since this is blocked by bug 236264

Ben Nham

Comment 16 2022-02-07 17:22:20 PST

Created attachment 451182 [details] Patch for landing

EWS

Comment 17 2022-02-07 18:59:44 PST

Committed r289353 (246941@main): <https://commits.webkit.org/246941@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451182 [details].

Kate Cheney

Comment 18 2022-02-14 11:25:03 PST

Comment on attachment 451182 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=451182&action=review > Source/WebKit/webpushd/WebPushDaemon.mm:621 > + // FIXME You may want to include more details in this fixme for future readability.

Note You need to log in before you can comment on or make changes to this bug.