Bug 235855

Summary: Forward messages from NetworkProcess to webpushd
Product: WebKit Reporter: Ben Nham <nham>
Component: New BugsAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, cdumez, esprehn+autocc, ews-watchlist, kangil.han, nham, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235857    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Ben Nham 2022-01-28 22:47:27 PST 
Forward messages from NetworkProcess to webpushd
Comment 1 Ben Nham 2022-01-28 22:48:13 PST 
Created attachment 450316 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2022-01-28 22:49:28 PST 
<rdar://problem/88218250>
Comment 3 Ben Nham 2022-01-29 12:44:51 PST 
Created attachment 450330 [details]
Patch
Comment 4 Ben Nham 2022-01-29 21:55:14 PST 
Created attachment 450350 [details]
Patch
Comment 5 Ben Nham 2022-01-29 22:40:14 PST 
Created attachment 450354 [details]
Patch
Comment 6 Brent Fulgham 2022-02-01 16:33:25 PST 
Comment on attachment 450354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450354&action=review

> Source/WebKit/webpushd/WebPushDaemon.mm:481
> +    UNUSED_PARAM(applicationServerKey);

Should we have any kind of MESSAGE_CHECK macros in here for connection, etc.? Maybe that comes later, once this is fleshed out more?
Comment 7 Ben Nham 2022-02-01 16:35:36 PST 
Comment on attachment 450354 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450354&action=review

>> Source/WebKit/webpushd/WebPushDaemon.mm:481
>> +    UNUSED_PARAM(applicationServerKey);
> 
> Should we have any kind of MESSAGE_CHECK macros in here for connection, etc.? Maybe that comes later, once this is fleshed out more?

Yeah, we check whether the parameters are sane in the full implementation (https://bugs.webkit.org/show_bug.cgi?id=235857).
Comment 8 EWS 2022-02-01 16:48:44 PST 
Committed r288929 (246660@main): <https://commits.webkit.org/246660@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450354 [details].