Bug 235665

Summary: Add copy-to-clipboard button for fuzzy matching meta tag
Product: WebKit Reporter: Jon Lee <jonlee>
Component: Tools / TestsAssignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, glenn, gsnedders, jbedard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=231828
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch darin: review+

Description Jon Lee 2022-01-26 12:36:14 PST 
.
Comment 1 Jon Lee 2022-01-26 12:41:12 PST 
Created attachment 450058 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-01-26 13:13:59 PST 
Comment on attachment 450058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450058&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_failures.py:217
> +            return 'maxDifference=0-{}; totalPixels=0-{}'.format(fuzzy_data['max_difference'], fuzzy_data['total_pixels'])

I worry that this is going to encourage 0-N ranges for all time, in all contexts. We really only want it for tests affected by accelerated drawing.
Comment 3 Jon Lee 2022-01-26 13:55:44 PST 
Created attachment 450066 [details]
Patch
Comment 4 Jon Lee 2022-01-26 16:32:05 PST 
Created attachment 450082 [details]
Patch
Comment 5 Simon Fraser (smfr) 2022-01-26 20:14:36 PST 
Need new results for the layout test that is also the diff page.
Comment 6 Jon Lee 2022-01-26 20:26:39 PST 
Created attachment 450098 [details]
Patch
Comment 7 Jon Lee 2022-01-26 20:41:24 PST 
Created attachment 450099 [details]
Patch
Comment 8 Jon Lee 2022-01-26 23:28:51 PST 
Created attachment 450105 [details]
Patch
Comment 9 Darin Adler 2022-01-27 16:39:07 PST 
Comment on attachment 450105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450105&action=review

rs=me

> LayoutTests/ChangeLog:11
> +        * fast/harness/image-diff-template-expected.txt:

Maybe at some point we can move this harness into a "resources" directory so we don’t have to also run it as a test?
Comment 10 Simon Fraser (smfr) 2022-01-27 16:41:20 PST 
I think running it as a test is a "feature".
Comment 11 Jon Lee 2022-01-28 10:09:36 PST 
Committed r288745 (246538@trunk): <https://commits.webkit.org/246538@trunk>
Comment 12 Radar WebKit Bug Importer 2022-01-28 10:10:17 PST 
<rdar://problem/88191824>