Bug 235531

Summary: Sort IDL extended attributes alphabetically
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: WebXRAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, msub2official, sam, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235527
Attachments:
Description Flags
Everywhere where EnabledBySetting comes before Conditional
none
Patch none

Sam Sneddon [:gsnedders]
Reported 2022-01-24 11:27:20 PST
Created attachment 449835 [details] Everywhere where EnabledBySetting comes before Conditional Per Darin in comment #2 on Bug 235527: > Comment on attachment 449829 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449829&action=review > > > Source/WebCore/Modules/webxr/XRFrameRequestCallback.idl:31 > > + EnabledBySetting=WebXREnabled, > > Conditional=WEBXR > > Normally we like to keep these alphabetical. The existing IDL should be fixed to adhere to this; this is almost entirely in WebXR & related testing IDL.
Attachments
Everywhere where EnabledBySetting comes before Conditional (5.86 KB, text/plain)
2022-01-24 11:27 PST, Sam Sneddon [:gsnedders] 		no flags
Details
Patch (29.27 KB, patch)
2022-03-27 01:07 PDT, Daniel Adams 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-01-31 11:28:19 PST
<rdar://problem/88284366>
Daniel Adams
Comment 2 2022-03-27 01:07:06 PDT
Created attachment 455864 [details] Patch
Sam Weinig
Comment 3 2022-03-27 08:36:28 PDT
Comment on attachment 455864 [details] Patch We should probably enforce this in the IDL parser for good measure at some point.
EWS
Comment 4 2022-03-27 19:36:24 PDT
Committed r291954 (248921@main): <https://commits.webkit.org/248921@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455864 [details].
Note You need to log in before you can comment on or make changes to this bug.