Bug 235530

Summary: [Forms] make sure :active is removed on keyup for radios
Product: WebKit Reporter: zsun
Component: FormsAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, koivisto, mifenton, ntim, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

zsun
Reported 2022-01-24 11:20:05 PST
WPT test- imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/radio-double-activate-pseudo.html
Attachments
Patch (1.39 KB, patch)
2022-01-24 11:24 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (1.89 KB, patch)
2022-02-03 01:26 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (3.63 KB, patch)
2022-05-17 01:49 PDT, zsun 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (2.73 KB, patch)
2022-05-19 02:12 PDT, zsun 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2022-01-24 11:24:45 PST
Created attachment 449834 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-01-31 11:21:46 PST
<rdar://problem/88283930>
zsun
Comment 3 2022-02-03 01:26:40 PST
Created attachment 450745 [details] Patch
Chris Dumez
Comment 4 2022-03-28 11:39:14 PDT
Comment on attachment 450745 [details] Patch Seems we need a layout test.
Tim Nguyen (:ntim)
Comment 5 2022-05-16 15:37:22 PDT
Why does html/semantics/forms/the-input-element/radio-double-activate-pseudo.html not start passing?
zsun
Comment 6 2022-05-17 01:49:44 PDT
Created attachment 459490 [details] Patch
zsun
Comment 7 2022-05-17 01:53:32 PDT
(In reply to Tim Nguyen (:ntim) from comment #5) > Why does > html/semantics/forms/the-input-element/radio-double-activate-pseudo.html not > start passing? bug 237589 corrected the test expectation file for test html/semantics/forms/the-input-element/radio-double-activate-pseudo.html. Patch has been updated and the test should pass now.
Chris Dumez
Comment 8 2022-05-17 07:56:24 PDT
Comment on attachment 459490 [details] Patch r=me
Tim Nguyen (:ntim)
Comment 9 2022-05-17 10:39:09 PDT
For this bug and bug 235522, note that changelogs are now deprecated (see the webkit-dev message), you'll need to use the Github workflow with a complete commit message.
zsun
Comment 10 2022-05-19 02:12:51 PDT
Created attachment 459573 [details] Patch
EWS
Comment 11 2022-05-19 04:37:47 PDT
Committed r294475 (250734@main): <https://commits.webkit.org/250734@main> Reviewed commits have been landed. Closing PR #773 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.