Bug 235516

Summary:	EWS results (GitHub checks) are not displayed while logged out from GitHub
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=235512 https://bugs.webkit.org/show_bug.cgi?id=235306 https://bugs.webkit.org/show_bug.cgi?id=235554

Description Aakash Jain 2022-01-24 07:41:11 PST

Currently, EWS results (default GitHub checks UI) are not displayed while logged out from GitHub. For e.g.: https://github.com/WebKit/WebKit/pull/89 (currently un-merged) shows the checks information while logged into GitHub, but doesn't show the information while logged out.

Not sure if this is critical, since reviewers would need to login to review the PR or leave any comments anyways. But it would probably be nice if the EWS results are displayed without logging in as well, e.g.: someone checking the PR on mobile to have a quick look if the PR is good, or bot-watchers looking at failing builds.

If someone have strong opinion on this, it would be good to know that.

Comment 1 Jonathan Bedard 2022-01-24 09:16:12 PST

Feels like the solution to this is what we're pursing: have EWS have a comment which it updates.

Comment 2 Radar WebKit Bug Importer 2022-01-31 07:42:18 PST

<rdar://problem/88269684>

Comment 3 Aakash Jain 2023-08-11 14:02:15 PDT

We now have EWS status-bubbles which don't have this problem.