Summary: | [Cocoa] Accelerated filters are enabled by the wrong setting | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
Component: | Layout and Rendering | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | annulen, benjamin, bfulgham, cdumez, changseok, cmarcelo, ddkilzer, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, ryuan.choi, schenney, sergio, simon.fraser, thorton, webkit-bug-importer, zalan | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=149424 https://bugs.webkit.org/show_bug.cgi?id=73842 https://bugs.webkit.org/show_bug.cgi?id=232831 |
||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 231253 | ||||||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2022-01-19 12:48:30 PST
Created attachment 449508 [details]
Patch
Created attachment 449539 [details]
Patch
Comment on attachment 449539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449539&action=review > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:414 > webcoreOnChange: setNeedsRelayoutAllFrames can we change the preference name to CoreImageAcceleratedFiltersEnabled or UseCoreImageForAcceleratedFilters? "filter render" is a weird term. > Source/WebCore/css/CSSFilterImageValue.cpp:118 > + auto renderingMode = renderer.page().acceleratedFilterRenderEnabled() ? RenderingMode::Accelerated : RenderingMode::Unaccelerated; "acceleratedFilterRender*ing*Enabled" I think would read more correctly, but also it could be simplified as above. Created attachment 449626 [details]
Patch
Created attachment 449627 [details]
Patch
Committed r288352 (246258@main): <https://commits.webkit.org/246258@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449627 [details]. |