| Summary: | CSP: Fix returned WebAssembly error type when blocked | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick Griffis <pgriffis> | ||||||||||||||
| Component: | New Bugs | Assignee: | Patrick Griffis <pgriffis> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | clopez, darin, ews-watchlist, katherine_cheney, keith_miller, mark.lam, mkwst, msaboff, saam, tzagallo, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 235408 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Patrick Griffis
2022-01-18 08:14:37 PST
Created attachment 449392 [details]
Patch
Created attachment 449393 [details]
Patch
Created attachment 449402 [details]
Patch
Comment on attachment 449402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449402&action=review Should imported/w3c/web-platform-tests/content-security-policy/wasm-unsafe-eval/script-src-spv-asynch.any.html and imported/w3c/web-platform-tests/content-security-policy/wasm-unsafe-eval/script-src-spv-asynch.any.serviceworker.html also be skipped? > LayoutTests/ChangeLog:8 > + Ignore CSP test that timesout. nit: should be a space between times and out. Comment on attachment 449402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449402&action=review Looks like a good change, but a lot of tests are failing on mac-wk1, please don’t land without investigating that. Also, this should be two patches, not as single patch. > Source/JavaScriptCore/wasm/js/JSWebAssemblyInstance.cpp:176 > + return exception(createJSWebAssemblyCompileError(globalObject, vm, globalObject->webAssemblyDisabledErrorMessage())); This should be two separate patches. First, import the tests. Then, add the fix and update the test results to show the newly-passing tests. Combining the two isn’t great. Created attachment 449419 [details]
Patch
(In reply to Darin Adler from comment #5) > Comment on attachment 449402 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449402&action=review > > Looks like a good change, but a lot of tests are failing on mac-wk1, please > don’t land without investigating that. Just no ServiceWorker there, skipped now. > This should be two separate patches. > > First, import the tests. > > Then, add the fix and update the test results to show the newly-passing > tests. > > Combining the two isn’t great. OK. Created attachment 449421 [details]
WPT: Import WebAssembly CSP tests
Created attachment 449422 [details]
CSP: Fix returned WebAssembly error type when blocked
(In reply to Kate Cheney from comment #4) > Comment on attachment 449402 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449402&action=review > > Should > imported/w3c/web-platform-tests/content-security-policy/wasm-unsafe-eval/ > script-src-spv-asynch.any.html and > imported/w3c/web-platform-tests/content-security-policy/wasm-unsafe-eval/ > script-src-spv-asynch.any.serviceworker.html also be skipped? > Indeed, added. Committed r288959 (246688@main): <https://commits.webkit.org/246688@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449421 [details]. Reopening as there was a second patch. Committed r288992 (246711@main): <https://commits.webkit.org/246711@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449422 [details]. |