Bug 235306

Summary: [github] Files changed and commits tabs become empty after merging the Pull Request
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aakash_jain
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235512
https://bugs.webkit.org/show_bug.cgi?id=235516
Attachments:
Description Flags
GitHub Merged PR Screenshot none

Aakash Jain
Reported 2022-01-17 17:18:30 PST
Created attachment 449358 [details] GitHub Merged PR Screenshot "Files changed" and "commits" tabs become empty after merging the Pull Request (screenshot attached). This makes it harder for anyone to re-review any pull-request (after it is merged), or to leave a comment on specific portion of the PR after it's merged. For example if I found an issue in the PR which was already merged, I would like to look at the PR code again and leave a comment at a specific line of code. I believe this is not the default github behavior, and is due to the way we (git-webkit) are handling the PRs.
Attachments
GitHub Merged PR Screenshot (707.48 KB, image/png)
2022-01-17 17:18 PST, Aakash Jain 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2022-01-18 10:07:33 PST
We won't be able to fix this. The reason this is happening is because we're aren't really merging the pull-request, we're landing the pull-request via SVN, then importing the SVN commit into git, updating the branch ref of the PR branch to match the landed commit and then closing the pull-request. Frankly, we're fortunate that GitHub actually marks such changes as "merged", BitBucket, for example, will not.
Note You need to log in before you can comment on or make changes to this bug.