Bug 235297
| Summary: | git-webkit setup should allow changing the credentials | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | aakash_jain, commit-queue, jbedard, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=235298 https://bugs.webkit.org/show_bug.cgi?id=237439 |
||
| Bug Depends on: | 236539 | ||
| Bug Blocks: | |||
Aakash Jain
git-webkit setup show allow changing the credentials. In case user made a mistake and entered incorrect credentials, there should be a way to either correct that or enter new credentials. Perhaps it can ask user if they want to update the stored credentials, and re-configure the correct remotes appropriately.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/87988794>
Jonathan Bedard
I think users would get a bit annoyed if their credentials were correct and we prompted them to validate them. My proposed change here is that we make an attempt to validate the user's credentials and prompt them only if the validation fails. I also think this applies to bugzilla credentials.
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/133
Jonathan Bedard
Landed 247173@main (r289687)
WebKit Commit Bot
Re-opened since this is blocked by bug 236539
Jonathan Bedard
247173@main (r289687) really should have been associated to https://bugs.webkit.org/show_bug.cgi?id=235298. I fixed the issue and re-landed that change.
I am going to close this as 'WONTFIX' because I think it will make `git-webkit setup` worse. I think that the validation will, in practice, do a good job of covering the use case in mind here, because I don't think someone having valid credentials in their keychain would want to overwrite them with different credentials, I think they would only want to overwrite invalid credentials, which is covered very well by https://bugs.webkit.org/show_bug.cgi?id=235298