Summary: | [LFC][IFC] Enable content with complex font codepath for IFC | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aboya, bfulgham, crzwdjk, dpino, ebrahim, jfernandez, koivisto, lmoura, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=235286 | ||||||||||
Attachments: |
|
Description
zalan
2022-01-15 06:24:47 PST
Created attachment 449252 [details]
Patch
Comment on attachment 449252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=449252&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-406 > - SET_REASON_AND_RETURN_IF_NEEDED(FlowHasComplexFontCodePath, reasons, includeReasons); Not removing FlowHasComplexFontCodePath? Created attachment 449254 [details]
Patch
(In reply to Antti Koivisto from comment #2) > Comment on attachment 449252 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=449252&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:-406 > > - SET_REASON_AND_RETURN_IF_NEEDED(FlowHasComplexFontCodePath, reasons, includeReasons); > > Not removing FlowHasComplexFontCodePath? good point! Created attachment 449258 [details]
Patch
Committed r288070 (246090@main): <https://commits.webkit.org/246090@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 449258 [details]. It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests started failing or timing out after this change: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI.WKInspectorExtension.EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI.WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI.WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI.WKInspectorExtensionDelegate.ExtensionTabNavigatedCallbacks&test=TestWebKitAPI.WKInspectorExtensionDelegate.InspectedPageNavigatedCallbacks&test=TestWebKitAPI.WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI.WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI.WKInspectorExtensionHost.UnregisterExtension (In reply to Wenson Hsieh from comment #8) > It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests > started failing or timing out after this change: > > https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI. > WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI. > WKInspectorExtension. > EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI. > WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI. > WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > ExtensionTabNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > InspectedPageNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI. > WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI. > WKInspectorExtensionHost.UnregisterExtension Odd. Will take a look. The TestWebKitAPI content triggers ASSERT(partialRun->length); in InlineContentBreaker::tryBreakingPreviousNonOverflowingRuns Interesting. Fixing it... (In reply to zalan from comment #10) > The TestWebKitAPI content triggers ASSERT(partialRun->length); in > InlineContentBreaker::tryBreakingPreviousNonOverflowingRuns > Interesting. Fixing it... Nope, the inspector content triggers the assert and not the test content. (In reply to Wenson Hsieh from comment #8) > It seems like several `TestWebKitAPI.WKInspectorExtension*` API tests > started failing or timing out after this change: > > https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api- > tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI. > WKInspectorExtension.CanEvaluateScriptInExtensionTab&test=TestWebKitAPI. > WKInspectorExtension. > EvaluateScriptInExtensionTabCanReturnPromises&test=TestWebKitAPI. > WKInspectorExtension.EvaluateScriptOnPage&test=TestWebKitAPI. > WKInspectorExtension.ExtensionTabIsPersistent&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > ExtensionTabNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate. > InspectedPageNavigatedCallbacks&test=TestWebKitAPI. > WKInspectorExtensionDelegate.ShowAndHideTabCallbacks&test=TestWebKitAPI. > WKInspectorExtensionHost.RegisterExtension&test=TestWebKitAPI. > WKInspectorExtensionHost.UnregisterExtension https://trac.webkit.org/changeset/288095/webkit should take care of these failures. Thanks! *** Bug 218510 has been marked as a duplicate of this bug. *** *** Bug 218930 has been marked as a duplicate of this bug. *** *** Bug 226474 has been marked as a duplicate of this bug. *** *** Bug 217421 has been marked as a duplicate of this bug. *** *** Bug 217946 has been marked as a duplicate of this bug. *** *** Bug 197277 has been marked as a duplicate of this bug. *** *** Bug 197409 has been marked as a duplicate of this bug. *** *** Bug 197411 has been marked as a duplicate of this bug. *** *** Bug 224590 has been marked as a duplicate of this bug. *** *** Bug 193491 has been marked as a duplicate of this bug. *** *** Bug 230414 has been marked as a duplicate of this bug. *** *** Bug 232910 has been marked as a duplicate of this bug. *** *** Bug 220942 has been marked as a duplicate of this bug. *** |