Summary: | cgColor() should have 'copy' or 'create' in the name (or return a RetainPtr) | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2009-01-23 20:49:37 PST
Also the implementation of Color(CGColorRef); is totally missing! Odd. ColorCG.cpp exists, but is not in the Xcode project. It also has an implementation of cgColor() that uses the platform color space. Created attachment 28014 [details] Patch Rename to createCGColor() per-irc conversation. This also fixes https://bugs.webkit.org/show_bug.cgi?id=24197 Comment on attachment 28014 [details]
Patch
Yay! I like this change. Of course I might get yelled at by bdash for my continued disparate understanding of PLATFORM(MAC) vs. PLATFORM(DARWIN). :(
DARWIN really seems wrong to me for the uses of CMProfileRef. For now, maybe !WIN_OS would be better, since the more limited version of CG is the one on Windows. Created attachment 28078 [details]
PLATFORM(WIN_OS)
Fix per Darin's comments.
Comment on attachment 28078 [details]
PLATFORM(WIN_OS)
r=me
|