Bug 234740

Summary: [GTK][a11y] Defer the emission of AddAccessible signal with ATSPI
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 234737    
Bug Blocks: 230253, 234750, 234781, 234808    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch aperez: review+, aperez: commit-queue-

Description Carlos Garcia Campos 2021-12-29 07:09:02 PST 
In case of node added and removed quickly, we just avoid the emission of the signal.
Comment 1 Carlos Garcia Campos 2021-12-29 07:17:00 PST 
Created attachment 448071 [details]
Patch
Comment 2 Carlos Garcia Campos 2021-12-30 03:15:33 PST 
Created attachment 448090 [details]
Patch
Comment 3 Carlos Garcia Campos 2021-12-30 05:30:29 PST 
Created attachment 448094 [details]
Patch
Comment 4 Carlos Garcia Campos 2021-12-30 06:12:24 PST 
Created attachment 448095 [details]
Patch
Comment 5 Adrian Perez 2022-01-11 06:29:54 PST 
This needs a rebase now that the patch for bug #234737 has landed =)
Comment 6 Carlos Garcia Campos 2022-01-11 08:48:39 PST 
(In reply to Adrian Perez from comment #5)
> This needs a rebase now that the patch for bug #234737 has landed =)

Yes, but I noticed some issues that I'm trying to fix.
Comment 7 Adrian Perez 2022-01-11 13:13:08 PST 
(In reply to Carlos Garcia Campos from comment #6)
> (In reply to Adrian Perez from comment #5)
> > This needs a rebase now that the patch for bug #234737 has landed =)
> 
> Yes, but I noticed some issues that I'm trying to fix.

Awesome, thanks!
Comment 8 Carlos Garcia Campos 2022-01-12 01:47:35 PST 
Created attachment 448916 [details]
Patch
Comment 9 Adrian Perez 2022-01-12 03:31:35 PST 
Comment on attachment 448916 [details]
Patch

Patch LGTM with a small nit to fix before landing 👍️

View in context: https://bugs.webkit.org/attachment.cgi?id=448916&action=review

> Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:-29
> -#include <wtf/NeverDestroyed.h>

Do not remove the line for <wtf/NeverDestroyed.h>, because it will break
non-unified builds.
Comment 10 Carlos Garcia Campos 2022-01-12 04:02:37 PST 
Committed r287918 (245951@trunk): <https://commits.webkit.org/245951@trunk>