Make -webkit-text-combine an inherited property

• Component: CSS
• Status: RESOLVED FIXED

[Tim Nguyen (:ntim)]

-webkit-text-combine is said to be inherited in CSSProperties.json, but it is not actually the case. It should be inherited per-spec (for text-combine-upright).

https://drafts.csswg.org/css-writing-modes/#text-combine-upright

[Tim Nguyen (:ntim)]

Some WPT actually exist for this:

css/css-writing-modes/text-combine-upright-inherit-all-001.html
css/css-writing-modes/text-combine-upright-inherit-all-002.html

[Tim Nguyen (:ntim)]

Created attachment 447983 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 447985 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 447985 [details]
Patch

Wrong bug

[Simon Fraser (smfr)]

Comment on attachment 447983 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447983&action=review

> LayoutTests/fast/text/text-combine-inherited.html:6
> +<link rel="author" title="Tim Nguyen" href="https://github.com/nt1m">
> +<link rel="match" href="text-combine-inherited-expected.html">

We don't normally add these to non-WPT tests.

[Tim Nguyen (:ntim)]

Created attachment 447991 [details]
[fast-cq] Patch

[EWS]

Committed r287451 (245586@main): <https://commits.webkit.org/245586@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447991 [details].

[Radar WebKit Bug Importer]

<rdar://problem/86923772>