Bug 234657

Summary: RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uint32_t
Product: WebKit Reporter: Yousuke Kimoto <Yousuke.Kimoto>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, chris.reid, don.olmstead, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, pangle, ross.kirsling, tomoki.imai, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yousuke Kimoto
Reported 2021-12-23 19:02:52 PST
https://bugs.webkit.org/show_bug.cgi?id=197243 fixed connection and target identifier types. ConnectionID is using ConnectionID = uint32_t; But currently connectionID is given to RemoteInspectorProtocolHandler::inspect() as "int" by the commit https://github.com/WebKit/WebKit/commit/695e0888fe0472f49fdc27da5f57d0f5e4353e51 m_inspectorProtocolHandler.inspect(requestURL.hostAndPort(), parseInteger<int>(tokens[0]).value_or(0), parseInteger<int>(tokens[1]).value_or(0), tokens[2]); It should be "uint32_t".
Attachments
Patch (1.64 KB, patch)
2021-12-23 19:25 PST, Yousuke Kimoto 		no flags
DetailsFormatted DiffDiff
Patch (1.65 KB, patch)
2021-12-26 10:07 PST, Yousuke Kimoto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yousuke Kimoto
Comment 1 2021-12-23 19:25:20 PST
Created attachment 447928 [details] Patch
Yousuke Kimoto
Comment 2 2021-12-26 10:07:02 PST
Created attachment 447976 [details] Patch The previous patch was wrong. The second parseInteger() should also be casted with "uint32_t".
EWS
Comment 3 2021-12-26 15:12:42 PST
Committed r287450 (245585@main): <https://commits.webkit.org/245585@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447976 [details].
Radar WebKit Bug Importer
Comment 4 2021-12-26 15:13:17 PST
<rdar://problem/86923496>
Note You need to log in before you can comment on or make changes to this bug.