Bug 234624

Summary: Fix WebKit Build issues when using system content path
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: PlatformAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dino, eric.carlson, ews-watchlist, fpizlo, jberlin, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch fpizlo: review+

Michael Saboff
Reported 2021-12-22 16:53:42 PST
A few more bugs in the recent config file changes for alternate root builds. - For frameworks nested under the WebCore framework, for macOS the directory needs to include the version, e.g. WebCore.framework/Versions/A/Frameworks instead of WebCore.framework/Frameworks. - WebKit needs to have SYSTEM_CONTENT_PATH added to the nested frameworks path (UMBRELLA_FRAMEWORKS_DIR). - WebCore and WebKitLegacy framework locations needs to have the SYSTEM_CONTENT_PATH added.
Attachments
Patch (13.35 KB, patch)
2021-12-22 17:25 PST, Michael Saboff 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2021-12-22 16:54:13 PST
<rdar://86828224>
Michael Saboff
Comment 2 2021-12-22 17:25:06 PST
Created attachment 447848 [details] Patch
EWS Watchlist
Comment 3 2021-12-22 17:26:21 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Jessie Berlin
Comment 4 2021-12-22 18:00:20 PST
Comment on attachment 447848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447848&action=review > Source/ThirdParty/ANGLE/ChangeLog:9 > + Deleted unussed create-symlink-to-altroot.sh script. Typo: "unussed"
Michael Saboff
Comment 5 2021-12-22 19:06:51 PST
(In reply to Jessie Berlin from comment #4) > Comment on attachment 447848 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447848&action=review > > > Source/ThirdParty/ANGLE/ChangeLog:9 > > + Deleted unussed create-symlink-to-altroot.sh script. > > Typo: "unussed" Fixed locally.
Michael Saboff
Comment 6 2021-12-22 19:10:26 PST
Committed r287382 (?): <https://commits.webkit.org/r287382>
Alexey Proskuryakov
Comment 7 2021-12-23 09:23:20 PST
Comment on attachment 447848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447848&action=review > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:35 > +INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH)$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks; What makes this macOS specific?
Alexey Proskuryakov
Comment 8 2022-01-04 14:29:01 PST
> What makes this macOS specific? Fixing this is tracked as bug 234857 now.
Note You need to log in before you can comment on or make changes to this bug.