Summary: | Fix WebKit Build issues when using system content path | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | Platform | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, dino, eric.carlson, ews-watchlist, fpizlo, jberlin, kbr, kondapallykalyan, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Michael Saboff
2021-12-22 16:53:42 PST
Created attachment 447848 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 447848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447848&action=review > Source/ThirdParty/ANGLE/ChangeLog:9 > + Deleted unussed create-symlink-to-altroot.sh script. Typo: "unussed" (In reply to Jessie Berlin from comment #4) > Comment on attachment 447848 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=447848&action=review > > > Source/ThirdParty/ANGLE/ChangeLog:9 > > + Deleted unussed create-symlink-to-altroot.sh script. > > Typo: "unussed" Fixed locally. Committed r287382 (?): <https://commits.webkit.org/r287382> Comment on attachment 447848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447848&action=review > Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:35 > +INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH)$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks; What makes this macOS specific? > What makes this macOS specific? Fixing this is tracked as bug 234857 now. |