Bug 234481

Summary: [libpas] Add macros to disable bmalloc core so that libpas can be enabled on 64-bit watchOS
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: bmallocAssignee: Yusuke Suzuki <ysuzuki>
Severity: Normal CC: fpizlo, ggaren, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 234416, 234478    
Bug Blocks:    
Description Flags
Patch none

Description David Kilzer (:ddkilzer) 2021-12-18 15:00:49 PST
Add macros to disable bmalloc core so that libpas can be enabled on 64-bit watchOS.

Bug 234416 enabled libpas on all 64-bit Apple platforms, but it didn't disable the core bmalloc code it replaced, so it caused a disk/shared memory regression of about 6 MB on arm64e on watchOS (and likely other OSes/architectures).

This bug is to add guards to core bmalloc code that libpas replaces so that it can be disabled at compile time (at least on watchOS), which would let us enable libpas on watchOS once again.

Note that Bug 234478 turned off libpas on 64-bit watchOS.
Comment 1 Radar WebKit Bug Importer 2021-12-18 15:01:29 PST
Comment 2 Yusuke Suzuki 2021-12-19 00:19:09 PST
Created attachment 447544 [details]
Comment 3 Yusuke Suzuki 2021-12-19 01:25:39 PST
Created attachment 447546 [details]
Comment 4 David Kilzer (:ddkilzer) 2021-12-19 08:30:15 PST
Comment on attachment 447546 [details]

r=me!  The mac-debug-wk1 failures I've seen on another patch--they aren't related.
Comment 5 EWS 2021-12-19 12:35:22 PST
Committed r287246 (245404@main): <https://commits.webkit.org/245404@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447546 [details].