Bug 234481

Summary: [libpas] Add macros to disable bmalloc core so that libpas can be enabled on 64-bit watchOS
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: bmallocAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 234416, 234478    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

David Kilzer (:ddkilzer)
Reported 2021-12-18 15:00:49 PST
Add macros to disable bmalloc core so that libpas can be enabled on 64-bit watchOS. Bug 234416 enabled libpas on all 64-bit Apple platforms, but it didn't disable the core bmalloc code it replaced, so it caused a disk/shared memory regression of about 6 MB on arm64e on watchOS (and likely other OSes/architectures). This bug is to add guards to core bmalloc code that libpas replaces so that it can be disabled at compile time (at least on watchOS), which would let us enable libpas on watchOS once again. Note that Bug 234478 turned off libpas on 64-bit watchOS.
Attachments
Patch (60.25 KB, patch)
2021-12-19 00:19 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (60.31 KB, patch)
2021-12-19 01:25 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-12-18 15:01:29 PST
<rdar://problem/86675567>
Yusuke Suzuki
Comment 2 2021-12-19 00:19:09 PST
Created attachment 447544 [details] Patch
Yusuke Suzuki
Comment 3 2021-12-19 01:25:39 PST
Created attachment 447546 [details] Patch
David Kilzer (:ddkilzer)
Comment 4 2021-12-19 08:30:15 PST
Comment on attachment 447546 [details] Patch r=me! The mac-debug-wk1 failures I've seen on another patch--they aren't related.
EWS
Comment 5 2021-12-19 12:35:22 PST
Committed r287246 (245404@main): <https://commits.webkit.org/245404@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447546 [details].
Note You need to log in before you can comment on or make changes to this bug.