| Summary: | [libpas] Do not compile libpas for 64-bit watchOS to save ~6 MB per architecture | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | bmalloc | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren, nham, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 234416 | ||||||
| Bug Blocks: | 234481 | ||||||
| Attachments: |
|
||||||
|
Description
David Kilzer (:ddkilzer)
2021-12-18 11:26:55 PST
Also going to disable it for tvOS to save space as it's not currently used there to my knowledge. Commit r287175 enabled libpas on all iOS family 64-bit architectures: [libpas] Enable libpas on ARM64 Darwin platforms (ARM64E is already enabled) https://bugs.webkit.org/show_bug.cgi?id=234416 https://commits.webkit.org/r287175 But the core of bmalloc itself is still compiled into the build, which means 64-bit watchOS architectures now consume an additional ~6 MB for libpas. Created attachment 447532 [details]
Patch v1
Comment on attachment 447532 [details]
Patch v1
r=me
Does watchOS include ARM64E slice? I thought it is only having ARM64_32 and ARMv7k. (In reply to Yusuke Suzuki from comment #5) > Does watchOS include ARM64E slice? I thought it is only having ARM64_32 and > ARMv7k. Yes, watchOS has three slices, including arm64e. Comment on attachment 447532 [details]
Patch v1
Adding cq+ since all Apple platforms have built.
Committed r287233 (245393@main): <https://commits.webkit.org/245393@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447532 [details]. |