Bug 234478

Summary: [libpas] Do not compile libpas for 64-bit watchOS to save ~6 MB per architecture
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: bmallocAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, nham, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 234416    
Bug Blocks: 234481    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2021-12-18 11:26:55 PST
Do not compile libpas for watchOS arm64e to save 6.15 MB. <rdar://85620647>
Attachments
Patch v1 (1.43 KB, patch)
2021-12-18 14:49 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-12-18 11:28:44 PST
Also going to disable it for tvOS to save space as it's not currently used there to my knowledge.
David Kilzer (:ddkilzer)
Comment 2 2021-12-18 14:48:43 PST
Commit r287175 enabled libpas on all iOS family 64-bit architectures: [libpas] Enable libpas on ARM64 Darwin platforms (ARM64E is already enabled) https://bugs.webkit.org/show_bug.cgi?id=234416 https://commits.webkit.org/r287175 But the core of bmalloc itself is still compiled into the build, which means 64-bit watchOS architectures now consume an additional ~6 MB for libpas.
David Kilzer (:ddkilzer)
Comment 3 2021-12-18 14:49:36 PST
Created attachment 447532 [details] Patch v1
Yusuke Suzuki
Comment 4 2021-12-18 14:55:53 PST
Comment on attachment 447532 [details] Patch v1 r=me
Yusuke Suzuki
Comment 5 2021-12-18 15:32:05 PST
Does watchOS include ARM64E slice? I thought it is only having ARM64_32 and ARMv7k.
David Kilzer (:ddkilzer)
Comment 6 2021-12-18 15:44:18 PST
(In reply to Yusuke Suzuki from comment #5) > Does watchOS include ARM64E slice? I thought it is only having ARM64_32 and > ARMv7k. Yes, watchOS has three slices, including arm64e.
David Kilzer (:ddkilzer)
Comment 7 2021-12-18 15:44:48 PST
Comment on attachment 447532 [details] Patch v1 Adding cq+ since all Apple platforms have built.
EWS
Comment 8 2021-12-18 16:22:38 PST
Committed r287233 (245393@main): <https://commits.webkit.org/245393@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447532 [details].
Note You need to log in before you can comment on or make changes to this bug.