Bug 233881

Summary: REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WebKitGTKAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bugs-noreply, don.olmstead, ews-watchlist, gyuyoung.kim, mmaxfield, ryuan.choi, sergio, zdobersek
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233803
Attachments:
Description Flags
[fast-cq] Buildfix patch
none
[fast-cq] Updated patch addressing WPE none

Lauro Moura
Reported 2021-12-06 10:30:26 PST
REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move
Attachments
[fast-cq] Buildfix patch (3.03 KB, patch)
2021-12-06 10:31 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
[fast-cq] Updated patch addressing WPE (4.20 KB, patch)
2021-12-06 19:11 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2021-12-06 10:31:40 PST
Created attachment 446050 [details] [fast-cq] Buildfix patch
EWS
Comment 2 2021-12-06 10:40:22 PST
Committed r286549 (244880@main): <https://commits.webkit.org/244880@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446050 [details].
Myles C. Maxfield
Comment 3 2021-12-06 11:36:48 PST
Sorry for causing this 😞 The EWS bots were green so I thought the rename was ready to go.
Lauro Moura
Comment 4 2021-12-06 11:51:35 PST
(In reply to Myles C. Maxfield from comment #3) > Sorry for causing this 😞 The EWS bots were green so I thought the rename > was ready to go. The EWS bots usually run incremental builds[1], triggering clean ones on failures. As the issue was actually happening on clean builds, this one flew under the EWS and post-commit bots radar. Actually, it was the newly added GTK EWS layout test bots that raised the alarm, as the GTK EWS builder and EWS API testers are more stable and don't always do clean builds. [1] IIRC, the `clean` in the checkout source step is related to `git clean` on the source tree, which ignores the build directory.
Lauro Moura
Comment 5 2021-12-06 18:54:59 PST
Reopening to address WPE and a few GTK tweaks
Lauro Moura
Comment 6 2021-12-06 19:11:37 PST
Created attachment 446110 [details] [fast-cq] Updated patch addressing WPE
EWS
Comment 7 2021-12-06 19:41:23 PST
Committed r286585 (?): <https://commits.webkit.org/r286585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446110 [details].
Note You need to log in before you can comment on or make changes to this bug.