| Summary: | REGRESSION(r286535) [GTK] Fix clean builds after DerivedSources/WebKit2 move | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||
| Component: | WebKitGTK | Assignee: | Lauro Moura <lmoura> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | annulen, bugs-noreply, don.olmstead, ews-watchlist, gyuyoung.kim, mmaxfield, ryuan.choi, sergio, zdobersek | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=233803 | ||||||||
| Attachments: |
|
||||||||
|
Description
Lauro Moura
2021-12-06 10:30:26 PST
Created attachment 446050 [details]
[fast-cq] Buildfix patch
Committed r286549 (244880@main): <https://commits.webkit.org/244880@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446050 [details]. Sorry for causing this 😞 The EWS bots were green so I thought the rename was ready to go. (In reply to Myles C. Maxfield from comment #3) > Sorry for causing this 😞 The EWS bots were green so I thought the rename > was ready to go. The EWS bots usually run incremental builds[1], triggering clean ones on failures. As the issue was actually happening on clean builds, this one flew under the EWS and post-commit bots radar. Actually, it was the newly added GTK EWS layout test bots that raised the alarm, as the GTK EWS builder and EWS API testers are more stable and don't always do clean builds. [1] IIRC, the `clean` in the checkout source step is related to `git clean` on the source tree, which ignores the build directory. Reopening to address WPE and a few GTK tweaks Created attachment 446110 [details]
[fast-cq] Updated patch addressing WPE
Committed r286585 (?): <https://commits.webkit.org/r286585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446110 [details]. |