Bug 233865

Summary: SourceBufferParser should be using contiguous shared buffer
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, benjamin, calvaris, cdumez, cgarcia, changseok, eric.carlson, esprehn+autocc, ews-watchlist, galpeter, glenn, gustavo, gyuyoung.kim, hi, hta, japhet, jbedard, jer.noble, joepeck, jsbell, kangil.han, keith_miller, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pangle, philipj, pnormand, rniwa, saam, sergio, tommyw, tzagallo, vjaquez, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 233677    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch for EWS
none
Patch for EWS
ews-feeder: commit-queue-
Patch
none
Patch none

Description Jean-Yves Avenard [:jya] 2021-12-05 22:51:22 PST 
The SourceBufferParser uses SharedBuffer but assert that those contain a single segment at most.

Follow-up on bug 233677.
Comment 1 Radar WebKit Bug Importer 2021-12-05 23:06:52 PST 
<rdar://problem/86085253>
Comment 2 Jean-Yves Avenard [:jya] 2021-12-05 23:25:40 PST 
Created attachment 446004 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-12-05 23:29:51 PST 
Created attachment 446007 [details]
Patch for EWS
Comment 4 Jean-Yves Avenard [:jya] 2021-12-07 01:34:17 PST 
Created attachment 446137 [details]
Patch for EWS
Comment 5 Eric Carlson 2021-12-14 08:39:06 PST 
Comment on attachment 446004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=446004&action=review

> Source/WebCore/ChangeLog:9
> +        Covered by existing tests, no observable differences.

It would be helpful to have a brief description of why this change was made here.
Comment 6 Jean-Yves Avenard [:jya] 2021-12-14 16:50:58 PST 
Created attachment 447178 [details]
Patch

Improve ChangeLog
Comment 7 Jean-Yves Avenard [:jya] 2021-12-14 16:53:48 PST 
Created attachment 447179 [details]
Patch

Add Reviewed-By line
Comment 8 EWS 2021-12-14 17:26:29 PST 
Committed r287059 (245255@main): <https://commits.webkit.org/245255@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447179 [details].