| Summary: | [ANGLE] clang with -Wunknown-warning-option will fail on -Wweak-template-vtables | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||
| Component: | ANGLE | Assignee: | Dean Jackson <dino> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, graouts, kbr, kkinnunen, kondapallykalyan, kpiddington, mjs, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 220896 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Dean Jackson
2021-12-03 12:49:48 PST
Created attachment 445891 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 445891 [details] Patch Looks fine, though please keep in mind this will collide with the big ANGLE upgrade Kyle's in the middle of in Bug 220896. Unless this is really pressing it might be better to wait for that to complete, but not sure how many blockers there are on that. r+ Agreed. This can wait until Kyle's roll lands, and maybe even come in the next roll if we can fix it upstream. Kyle's mega-roll landed in Bug 220896 - would it be feasible to upload this patch to ANGLE's code review tool instead, and pick it up by rolling forward ANGLE again? This is breaking a build internally so I'm not sure it can wait? Landing this now would be fine if it can't quickly/easily be uploaded to ANGLE's issue tracker. Kyle's landing a follow-on roll right now in Bug 234317 - but it doesn't include this fix. An update on this. It seems I can't use __has_warning everywhere, so I'll try to add a new CFLAG for -Wno-unknown-warning-option Created attachment 447250 [details]
Patch
Committed r287082 (245277@trunk): <https://commits.webkit.org/245277@trunk> |