Bug 233804

Summary:

[GTK][a11y] Ensure atspi wrappers have root set at construction time

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=234737

Bug Depends on:

Bug Blocks:

230253

Attachments:

Description	Flags
Patch	jdiggs: review+

Description Carlos Garcia Campos 2021-12-03 01:25:37 PST

It simplifies the code a lot and we ensure all wrappers always have a link to the root element.

Comment 1 Carlos Garcia Campos 2021-12-03 01:36:12 PST

Created attachment 445823 [details]
Patch

Comment 2 Joanmarie Diggs 2021-12-03 02:05:20 PST

Comment on attachment 445823 [details]
Patch

Thanks for doing this!

Comment 3 Adrian Perez 2021-12-03 02:10:21 PST

Comment on attachment 445823 [details]
Patch

Very nice to see quite a few parts of the ATSPI code simplified by
this patch. As usual, patches that remove code are among the nicest 😻️

Comment 4 Carlos Garcia Campos 2021-12-09 00:26:45 PST

Committed r286767 (245008@trunk): <https://commits.webkit.org/245008@trunk>