Bug 233804

Summary: [GTK][a11y] Ensure atspi wrappers have root set at construction time
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=234737
Bug Depends on:    
Bug Blocks: 230253    
Attachments:
Description Flags
Patch jdiggs: review+

Carlos Garcia Campos
Reported 2021-12-03 01:25:37 PST
It simplifies the code a lot and we ensure all wrappers always have a link to the root element.
Attachments
Patch (42.69 KB, patch)
2021-12-03 01:36 PST, Carlos Garcia Campos 		jdiggs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-12-03 01:36:12 PST
Created attachment 445823 [details] Patch
Joanmarie Diggs
Comment 2 2021-12-03 02:05:20 PST
Comment on attachment 445823 [details] Patch Thanks for doing this!
Adrian Perez
Comment 3 2021-12-03 02:10:21 PST
Comment on attachment 445823 [details] Patch Very nice to see quite a few parts of the ATSPI code simplified by this patch. As usual, patches that remove code are among the nicest 😻️
Carlos Garcia Campos
Comment 4 2021-12-09 00:26:45 PST
Committed r286767 (245008@trunk): <https://commits.webkit.org/245008@trunk>
Note You need to log in before you can comment on or make changes to this bug.