Bug 233677

Summary:

Distinguish contiguous SharedBuffer from non-contiguous one and guarantee immutability: part 3

Product:

WebKit

Reporter:

Jean-Yves Avenard [:jya] <jean-yves.avenard>

Component:

WebCore Misc.

Assignee:

Jean-Yves Avenard [:jya] <jean-yves.avenard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, beidson, benjamin, berto, calvaris, cdumez, cgarcia, changseok, eric.carlson, esprehn+autocc, ews-watchlist, galpeter, glenn, gustavo, gyuyoung.kim, hi, hta, japhet, jbedard, jer.noble, joepeck, jsbell, kangil.han, keith_miller, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pangle, philipj, pnormand, rniwa, saam, sergio, tommyw, tzagallo, vjaquez, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

233030, 233442

Bug Blocks:

233865

Attachments:

Description	Flags
WIP	none
WIP	none
Patch for EWS	none
WIP	none
WIP	none
WIP	none
Patch for EWS	ews-feeder: commit-queue-
Patch	none
Patch for EWS	none
Patch for EWS	none
Patch	none
Patch for EWS	none
Patch for EWS	none
Patch for EWS	none
Patch	none
Patch	none
Patch for EWS	none
Patch for EWS	none
Patch for EWS	ews-feeder: commit-queue-
Patch for EWS	none
Patch for review	none
Patch for EWS	none
Patch for review	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Description Jean-Yves Avenard [:jya] 2021-11-30 20:20:53 PST

This is part 3 of bug 233030 and As per https://bugs.webkit.org/show_bug.cgi?id=233030#c40

SharedBuffer base class will be renamed FragmentedSharedBuffer
ContiguousSharedBuffer will be renamed SharedBuffer

Comment 1 Radar WebKit Bug Importer 2021-12-02 03:20:57 PST

<rdar://problem/85963900>

Comment 2 Jean-Yves Avenard [:jya] 2021-12-02 03:35:32 PST

Created attachment 445700 [details]
WIP

Comment 3 Jean-Yves Avenard [:jya] 2021-12-02 03:41:18 PST

Created attachment 445701 [details]
WIP

Comment 4 EWS Watchlist 2021-12-02 03:42:24 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 5 Jean-Yves Avenard [:jya] 2021-12-03 03:52:14 PST

Created attachment 445834 [details]
Patch for EWS

Comment 6 Jean-Yves Avenard [:jya] 2021-12-03 04:09:53 PST

Created attachment 445838 [details]
WIP

Comment 7 Jean-Yves Avenard [:jya] 2021-12-03 07:23:32 PST

Created attachment 445849 [details]
WIP

Comment 8 Jean-Yves Avenard [:jya] 2021-12-03 07:25:44 PST

Created attachment 445850 [details]
WIP

Comment 9 Jean-Yves Avenard [:jya] 2021-12-03 17:16:34 PST

Created attachment 445929 [details]
Patch for EWS

Comment 10 Jean-Yves Avenard [:jya] 2021-12-03 17:24:55 PST

Created attachment 445931 [details]
Patch

Comment 11 Jean-Yves Avenard [:jya] 2021-12-03 20:09:13 PST

Created attachment 445947 [details]
Patch for EWS

Comment 12 Jean-Yves Avenard [:jya] 2021-12-04 17:18:57 PST

Created attachment 445971 [details]
Patch for EWS

Comment 13 Jean-Yves Avenard [:jya] 2021-12-05 22:43:19 PST

Created attachment 445998 [details]
Patch

Fix test failures

Comment 14 Jean-Yves Avenard [:jya] 2021-12-05 22:44:43 PST

Created attachment 445999 [details]
Patch for EWS

Comment 15 Jean-Yves Avenard [:jya] 2021-12-05 23:27:18 PST

Created attachment 446006 [details]
Patch for EWS

Comment 16 Jean-Yves Avenard [:jya] 2021-12-05 23:27:55 PST

Comment on attachment 446006 [details]
Patch for EWS

this patch is for another bug

Comment 17 Jean-Yves Avenard [:jya] 2021-12-06 04:37:29 PST

Created attachment 446026 [details]
Patch for EWS

rebase

Comment 18 Jean-Yves Avenard [:jya] 2021-12-06 04:39:07 PST

Created attachment 446027 [details]
Patch

Comment 19 Jean-Yves Avenard [:jya] 2021-12-07 01:23:51 PST

Created attachment 446135 [details]
Patch

rebase

Comment 20 Jean-Yves Avenard [:jya] 2021-12-07 01:25:15 PST

Created attachment 446136 [details]
Patch for EWS

rebase following changes in bug 233030

Comment 21 Jean-Yves Avenard [:jya] 2021-12-07 04:12:40 PST

Created attachment 446153 [details]
Patch for EWS

Comment 22 Jean-Yves Avenard [:jya] 2021-12-07 04:15:08 PST

Comment on attachment 446153 [details]
Patch for EWS

webkit-patch is getting confused by those patch for EWS

Comment 23 Jean-Yves Avenard [:jya] 2021-12-09 05:36:22 PST

Created attachment 446528 [details]
Patch for EWS

rebase

Comment 24 Jean-Yves Avenard [:jya] 2021-12-09 06:24:36 PST

Created attachment 446535 [details]
Patch for EWS

rebase 2

Comment 25 Jean-Yves Avenard [:jya] 2021-12-09 06:26:34 PST

Created attachment 446536 [details]
Patch for review

Comment 26 Jean-Yves Avenard [:jya] 2021-12-13 08:34:53 PST

Created attachment 447006 [details]
Patch for EWS

rebase

Comment 27 Jean-Yves Avenard [:jya] 2021-12-13 08:36:34 PST

Created attachment 447007 [details]
Patch for review

Comment 28 youenn fablet 2021-12-13 08:53:35 PST

r=me once bots are happy

Comment 29 Jean-Yves Avenard [:jya] 2021-12-13 15:52:20 PST

Created attachment 447077 [details]
Patch

fix bad earlier rebase

Comment 30 Jean-Yves Avenard [:jya] 2021-12-13 16:30:04 PST

Created attachment 447083 [details]
Patch

ios build fix

Comment 31 Jean-Yves Avenard [:jya] 2021-12-13 21:45:58 PST

Created attachment 447107 [details]
Patch

fix rebase error, side fix to GStreamerEMEUtilities and clients, checking for null

Comment 32 youenn fablet 2021-12-14 00:36:18 PST

Comment on attachment 447107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=447107&action=review

> Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:44
> +TEST_F(FragmentedSharedBufferTest, createWithContentsOfMissingFile)

Are some of these tests worth being duplicated for SharedBuffer as well?

Comment 33 Jean-Yves Avenard [:jya] 2021-12-14 02:14:36 PST

(In reply to youenn fablet from comment #32)
> Comment on attachment 447107 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=447107&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:44
> > +TEST_F(FragmentedSharedBufferTest, createWithContentsOfMissingFile)
> 
> Are some of these tests worth being duplicated for SharedBuffer as well?

Thanks for the review. 

I don’t see much values in having extra tests specifically for contiguous buffer no.

Comment 34 EWS 2021-12-14 02:49:16 PST

Committed r287021 (245226@main): <https://commits.webkit.org/245226@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447107 [details].