Bug 233566

Summary: Make support for WebKitAdditions in Framework headers conditional based on deployment target
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: kkinnunen, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 233374    
Bug Blocks: 233569    
Attachments:
Description Flags
Patch wenson_hsieh: review+

Description Chris Dumez 2021-11-29 09:33:02 PST
Make support for WebKitAdditions in Framework headers conditional based on deployment target.
Comment 1 Chris Dumez 2021-11-29 09:34:26 PST
Created attachment 445285 [details]
Patch
Comment 2 Wenson Hsieh 2021-11-29 11:17:47 PST
Comment on attachment 445285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445285&action=review

> Source/WebKit/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

While the change is pretty self-explanatory, I think a brief sentence here enumerating the supported OS versions might still be helpful.
Comment 3 Chris Dumez 2021-11-29 11:57:25 PST
Committed r286250 (244613@main): <https://commits.webkit.org/244613@main>
Comment 4 Radar WebKit Bug Importer 2021-11-29 11:58:28 PST
<rdar://problem/85828458>