Bug 233515

Summary: GraphicsContextGLANGLE.cpp has platform specific code
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cmarcelo, dino, ews-watchlist, gyuyoung.kim, Hironori.Fujii, kbr, kkinnunen, koivisto, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221664, 233589    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Kimmo Kinnunen 2021-11-26 00:25:45 PST 
GraphicsContextGLANGLE.cpp has platform specific code

This should be invoked through virtual functions and the code should be moved to the platform specific implementations
This way platform specific implementation like GraphicsContextGLOpenGL Cocoa flavour can be in future be called GraphicsContextGLCocoa, since GraphicsContextGLOpenGL and GraphicsContextGLANGLE would be also separate classes.
Comment 1 Kimmo Kinnunen 2021-11-26 00:30:35 PST 
Created attachment 445175 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-11-26 03:27:56 PST 
Created attachment 445186 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-11-26 05:19:18 PST 
Created attachment 445190 [details]
Patch
Comment 4 Kimmo Kinnunen 2021-11-26 05:24:15 PST 
Created attachment 445191 [details]
Patch
Comment 5 Kimmo Kinnunen 2021-11-26 05:53:35 PST 
Created attachment 445195 [details]
Patch
Comment 6 Kimmo Kinnunen 2021-11-26 05:58:21 PST 
Created attachment 445196 [details]
Patch
Comment 7 EWS 2021-11-29 01:41:26 PST 
Committed r286205 (244587@main): <https://commits.webkit.org/244587@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445196 [details].
Comment 8 Radar WebKit Bug Importer 2021-11-29 01:42:22 PST 
<rdar://problem/85803889>
Comment 9 Fujii Hironori 2021-11-29 12:51:05 PST 
This change broke WinCairo WebGL tests.
Filed: Bug 233589 – REGRESSION(r286205) [WinCairo] WebGL tests are failing