Summary: | check-webkit-style: regenerate localized strings when LocalizedStrings source files change | ||
---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | ap, jbedard, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=232642 |
Description
David Kilzer (:ddkilzer)
2021-11-24 15:30:46 PST
should this be part of style checker? Webkit-patch changes would only help people who use webkit-patch. webkit-patch invokes check-webkit-style (as will git-webkit), that's the right place to do this sort of thing. My thinking was that knowledge of the changed files in the patch being uploaded would be needed in order to make a decision about whether this check needs to be done, and webkit-patch would have that (not check-WebKit-style). For example, if LocalizedStrings.cpp or LocalizedStringsCocoa.mm changed, then this should be checked, but otherwise it should not (to save time). I guess the actual code to do the checking could be in check-webkit-style, and the logic about whether to run the checker could be in webkit-patch, though. (In reply to David Kilzer (:ddkilzer) from comment #3) > My thinking was that knowledge of the changed files in the patch being > uploaded would be needed in order to make a decision about whether this > check needs to be done, and webkit-patch would have that (not > check-WebKit-style). > > For example, if LocalizedStrings.cpp or LocalizedStringsCocoa.mm changed, > then this should be checked, but otherwise it should not (to save time). > > I guess the actual code to do the checking could be in check-webkit-style, > and the logic about whether to run the checker could be in webkit-patch, > though. check-webkit-style actually owns the knowledge of the changed files, since it only operates on the blocks of code a user is changing |