Bug 233360

Summary: Network process does not seem to initialize logging
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebKit2Assignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, fujii.hironori, heycam, jer.noble, jiewen_tan, kkinnunen, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237311
Attachments:
Description Flags
Patch
none
Patch none

Kimmo Kinnunen
Reported 2021-11-19 04:48:01 PST
Network process does not seem to initialize logging Tools/Scripts/run-minibrowser --debug -WebKit2Logging IPCMessages does not seem to print IPC logging for network process.
Attachments
Patch (40.89 KB, patch)
2021-12-02 01:44 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (40.70 KB, patch)
2021-12-02 01:48 PST, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-26 04:48:20 PST
<rdar://problem/85765854>
Kimmo Kinnunen
Comment 2 2021-12-02 01:44:03 PST
Created attachment 445693 [details] Patch
Kimmo Kinnunen
Comment 3 2021-12-02 01:48:38 PST
Created attachment 445694 [details] Patch
Fujii Hironori
Comment 4 2021-12-02 20:15:12 PST
Comment on attachment 445694 [details] Patch Because GTK, WPE and Windows ports are using env vars for logging settings, they don't need this change. However, I think this is a good idea. LGTM.
EWS
Comment 5 2021-12-03 00:06:18 PST
Committed r286484 (244823@main): <https://commits.webkit.org/244823@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445694 [details].
Jer Noble
Comment 6 2022-02-24 20:00:05 PST
This change broke the ability to set logging channel levels through NSUserDefaults.
Jer Noble
Comment 7 2022-02-24 20:02:47 PST
In r227822, we showed that logLevelString() returns the empty string for release builds. This patch undid that change, and returned the previous behavior of effectively disabling all non-error logging in release builds, affecting our ability to collect debug logs with a NSUserDefaults change.
Note You need to log in before you can comment on or make changes to this bug.