Bug 233248

Summary: AX: Use ObjectIdentifier for AXID
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233004
Bug Depends on: 233260    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Carlos Garcia Campos
Reported 2021-11-17 02:58:19 PST
Use ObjectIdentifier for AXID.
Attachments
Patch (22.88 KB, patch)
2021-11-17 03:00 PST, Carlos Garcia Campos 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (23.55 KB, patch)
2021-11-17 03:45 PST, Carlos Garcia Campos 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (27.37 KB, patch)
2021-11-17 05:08 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.37 KB, patch)
2021-11-18 00:49 PST, Carlos Garcia Campos 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (29.34 KB, patch)
2021-11-18 01:11 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-17 02:58:48 PST
<rdar://problem/85497145>
Carlos Garcia Campos
Comment 2 2021-11-17 03:00:05 PST
Created attachment 444503 [details] Patch
Carlos Garcia Campos
Comment 3 2021-11-17 03:45:55 PST
Created attachment 444505 [details] Patch
Carlos Garcia Campos
Comment 4 2021-11-17 05:08:10 PST
Created attachment 444509 [details] Patch
Tyler Wilcock
Comment 5 2021-11-17 08:13:59 PST
I re-ran the tests with this patch and the results look good to me for Clang + Mac. (re-posting https://bugs.webkit.org/show_bug.cgi?id=233004#c5) My main is currently at revision: https://github.com/WebKit/WebKit/commit/ce9ed8749594cb74cb8b154c56c91a8fe0bac858 Main: 161 text failures, 3 crashes, 8 timeouts Main + patch https://bugs.webkit.org/attachment.cgi?id=444509&action=prettypatch: 160 text failures, 2 crashes, 9 timeouts
EWS
Comment 6 2021-11-17 10:14:34 PST
Committed r285934 (244343@main): <https://commits.webkit.org/244343@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444509 [details].
WebKit Commit Bot
Comment 7 2021-11-17 10:25:37 PST
Re-opened since this is blocked by bug 233260
Carlos Garcia Campos
Comment 8 2021-11-18 00:49:44 PST
Created attachment 444645 [details] Patch for landing
Carlos Garcia Campos
Comment 9 2021-11-18 01:11:33 PST
Created attachment 444647 [details] Patch for landing
Carlos Garcia Campos
Comment 10 2021-11-18 01:51:52 PST
Committed r285991 (244388@main): <https://commits.webkit.org/244388@main>
Note You need to log in before you can comment on or make changes to this bug.