Bug 233211

Summary: [LBSE] Add runtime flag for Layer-based SVG engine (LBSE)
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, jbedard, ryuan.choi, sabouhallawa, sam, sergio, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=239877
Bug Depends on:    
Bug Blocks: 90738, 233666    
Attachments:
Description Flags
Patch, v1
none
Patch, v2 none

Nikolas Zimmermann
Reported 2021-11-16 14:08:03 PST
Add first bits of the Layer-Based SVG Engine (LBSE). The plan is to upstream the LBSE (https://github.com/nikolaszimmermann/WebKitIgalia/commits/main) behind a runtime flag (+ build option), off by default, according to the strategy outlined in https://blogs.igalia.com/nzimmermann/posts/2021-10-29-layer-based-svg-engine/page/8/#svg-poc-upstreaming. Let's get it started :-)
Attachments
Patch, v1 (8.87 KB, patch)
2021-11-16 14:50 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v2 (12.91 KB, patch)
2021-11-25 15:35 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2021-11-16 14:50:52 PST
Created attachment 444438 [details] Patch, v1
Radar WebKit Bug Importer
Comment 2 2021-11-23 14:08:21 PST
<rdar://problem/85711597>
Nikolas Zimmermann
Comment 3 2021-11-25 15:35:40 PST
Created attachment 445159 [details] Patch, v2
Nikolas Zimmermann
Comment 4 2021-11-25 15:39:18 PST
Per Slack feedback, without RuntimeEnabledFeatures.
Sam Weinig
Comment 5 2021-11-27 15:57:15 PST
Comment on attachment 445159 [details] Patch, v2 Looks good. Once things are a bit farther along it will probably make sense to move the flag from Internal to Experimental, but this seems right for now. r=me
Nikolas Zimmermann
Comment 6 2021-11-28 23:41:46 PST
(In reply to Sam Weinig from comment #5) > Comment on attachment 445159 [details] > Patch, v2 > > Looks good. Once things are a bit farther along it will probably make sense > to move the flag from Internal to Experimental, but this seems right for now. Thanks Sam!
EWS
Comment 7 2021-11-29 00:27:12 PST
Committed r286204 (244586@main): <https://commits.webkit.org/244586@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445159 [details].
Note You need to log in before you can comment on or make changes to this bug.