Bug 233666 - [LBSE] Rename RenderSVGRoot -> LegacyRenderSVGRoot
Summary: [LBSE] Rename RenderSVGRoot -> LegacyRenderSVGRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords: InRadar
Depends on: 233211
Blocks: 90738 233863 233870
  Show dependency tree / graph
 
Reported: 2021-11-30 15:33 PST by Nikolas Zimmermann
Modified: 2022-01-05 04:41 PST (History)
28 users (show)

See Also:

Attachments
Patch, v1 (111.53 KB, patch)
2021-11-30 15:45 PST, Nikolas Zimmermann 		rbuis: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2021-11-30 15:33:18 PST 
Let's start with moving RenderSVGRoot -> LegacyRenderSVGRoot.
A follow-up patch will introduce the new RenderSVGRoot stub implementation. After that switching from LBSE to legacy engine and back has a visual effect (LBSE enabled == nothing renderered).

After some experimentation on how to upstream, I found that starting from a clean RenderSVGRoot is the easiest approach.
Comment 1 Nikolas Zimmermann 2021-11-30 15:45:01 PST 
Created attachment 445481 [details]
Patch, v1
Comment 2 Nikolas Zimmermann 2021-12-01 15:52:37 PST 
Committed r286392 (244748@main): <https://commits.webkit.org/244748@main>
Comment 3 Radar WebKit Bug Importer 2021-12-01 15:53:24 PST 
<rdar://problem/85943424>