Bug 232905

Summary: Upstream: Fix occlusion query buffer synchronization in angle end2end tests
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230749
Attachments:
Description Flags
Patch kkinnunen: review+, ews-feeder: commit-queue-

Description Kyle Piddington 2021-11-09 14:12:29 PST 
Upstream: Fix occlusion query buffer synchronization in angle end2end tests
Comment 1 Kyle Piddington 2021-11-09 14:13:10 PST 
Created attachment 443727 [details]
Patch
Comment 2 EWS Watchlist 2021-11-09 14:14:11 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kimmo Kinnunen 2021-11-10 09:12:06 PST 
Comment on attachment 443727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443727&action=review

looks good with the nits fixed

> Source/ThirdParty/ANGLE/ChangeLog:6
> +	Ensure that GPU synchronization is flushed before

ChangeLog needs a certain format, these need the tabs

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.h:91
> +         // encoded on the GPU, and a map operation must wait

comment lines don't align
Comment 4 Radar WebKit Bug Importer 2021-11-16 14:13:18 PST 
<rdar://problem/85474799>
Comment 5 Kyle Piddington 2022-01-19 11:15:21 PST 
Fixed in 
Roll ANGLE to include upstreamed Metal backend
https://bugs.webkit.org/show_bug.cgi?id=220896
<rdar://problem/73539682>

*** This bug has been marked as a duplicate of bug 220896 ***