Bug 23283

Summary: Optimize RenderBox::localToAbsoluteQuad() to use LayoutState
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 24163    
Bug Blocks:    
Attachments:
Description Flags
Patch, changelog eric: review+

Simon Fraser (smfr)
Reported 2009-01-12 21:23:38 PST
RenderBox::localToAbsoluteQuad() shows up in some profiles for deeply nested content. It should be fixed to use LayoutState when possible.
Attachments
Patch, changelog (1.46 KB, patch)
2009-01-12 21:30 PST, Simon Fraser (smfr) 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-01-12 21:30:01 PST
Created attachment 26660 [details] Patch, changelog
Eric Seidel (no email)
Comment 2 2009-02-06 14:01:00 PST
Comment on attachment 26660 [details] Patch, changelog This looks sane to me. I can't promise I'm an expert in this code though. You might yet want Hyatt or Mitz to look at this. But as I said above, it looks right by my eyes.
Simon Fraser (smfr)
Comment 3 2009-03-12 11:26:57 PDT
Got done as part of the patch in bug 24163.
Note You need to log in before you can comment on or make changes to this bug.