Bug 23283

Summary:

Optimize RenderBox::localToAbsoluteQuad() to use LayoutState

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Bug Depends on:

24163

Bug Blocks:

Attachments:

Description	Flags
Patch, changelog	eric: review+

Description Simon Fraser (smfr) 2009-01-12 21:23:38 PST

RenderBox::localToAbsoluteQuad() shows up in some profiles for deeply nested content. It should be fixed to use LayoutState when possible.

Comment 1 Simon Fraser (smfr) 2009-01-12 21:30:01 PST

Created attachment 26660 [details]
Patch, changelog

Comment 2 Eric Seidel (no email) 2009-02-06 14:01:00 PST

Comment on attachment 26660 [details]
Patch, changelog

This looks sane to me.  I can't promise I'm an expert in this code though.  You might yet want Hyatt or Mitz to look at this.  But as I said above, it looks right by my eyes.

Comment 3 Simon Fraser (smfr) 2009-03-12 11:26:57 PDT

Got done as part of the patch in bug 24163.