| Summary: | css2.1/t1205-c566-list-stl-00-e-ag.html is failing | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pierre-Olivier Latour <pol> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | darin, dglazkov, hamaji, hyatt, mitz | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Mac | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Pierre-Olivier Latour
2009-01-12 13:01:21 PST
Created attachment 42522 [details]
Patch v1
This patch will fix Bug 23262 as well. The following URL would describe this bug well: http://tinyurl.com/yf2vux5 Comment on attachment 42522 [details]
Patch v1
Shouldn’t there be a matching change to RenderBlock::calcInlinePrefWidths()?
(In reply to comment #3) > (From update of attachment 42522 [details]) > Shouldn’t there be a matching change to RenderBlock::calcInlinePrefWidths()? Ah, true. This bug happens even without list-style-position:inside. I filed Bug 31619 for this issue. Thanks for this very nice catch! *** Bug 31619 has been marked as a duplicate of this bug. *** Created attachment 43436 [details] Patch v2 I merged patch with Bug 31619's. It seems Qt version of buildbot was updated (http://trac.webkit.org/changeset/50878) and I think I need to upgrade my Qt version to produce correct expectations. Please let me mark them as skipped for now. I'll fix them later. WebKit’s current behavior matches Firefox and appears to be intentional. Not sure this bug is valid. Comment on attachment 43436 [details]
Patch v2
If we do the right thing for outside list markers, then it seems like you should just be able to drop the !inside checks and have the right thing happen rather than adding new code.
I agree that this is a bug, and that we should fix the behavior. Created attachment 43581 [details] Patch v3 > If we do the right thing for outside list markers, then it seems like you > should just be able to drop the !inside checks and have the right thing happen > rather than adding new code. Ah yes, I was confused. I updated my patch. Could you take a look again? David and Dan, could you take another look at the updated patch? I think I addressed all of your comments. Thanks! Committed r51527: <http://trac.webkit.org/changeset/51527> |