Summary: | perspective() <= 1px should be clamped to 1px | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||||||
Component: | CSS | Assignee: | Martin Robinson <mrobinson> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 232618 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Martin Robinson
2021-11-02 05:09:18 PDT
Created attachment 445729 [details]
Patch
Comment on attachment 445729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445729&action=review > Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:68 > + return m_interoperabilityState == TransformInteropabilityEnabled ? std::max(1.0f, returnValue) : returnValue; Not sure if it's worth plumbing ScriptExecutionContext all the way through just to check the setting here. I bet we could do this without undue compat risk. Created attachment 445848 [details]
Patch
Created attachment 446028 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 445729 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445729&action=review > > > Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:68 > > + return m_interoperabilityState == TransformInteropabilityEnabled ? std::max(1.0f, returnValue) : returnValue; > > Not sure if it's worth plumbing ScriptExecutionContext all the way through > just to check the setting here. I bet we could do this without undue compat > risk. Thanks for the review. I've updated the patch to remove the plumbing and also updated the WebKit-specific tests that were failing. Created attachment 446131 [details]
Patch
Committed r286591 (?): <https://commits.webkit.org/r286591> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446131 [details]. |