Bug 232462

Summary: Remove code inside ENABLE(NETSCAPE_PLUGIN_API)
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, annulen, benjamin, bfulgham, cdumez, changseok, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, sergio, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232519
https://bugs.webkit.org/show_bug.cgi?id=270068
Bug Depends on:    
Bug Blocks: 232642, 237555    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Alex Christensen
Reported 2021-10-28 16:28:22 PDT
Remove code inside ENABLE(NETSCAPE_PLUGIN_API)
Attachments
Patch (1.58 MB, patch)
2021-10-28 16:30 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.58 MB, patch)
2021-10-28 17:59 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (1.59 MB, patch)
2021-10-28 20:44 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-28 16:30:00 PDT
Created attachment 442764 [details] Patch
Alex Christensen
Comment 2 2021-10-28 17:59:35 PDT
Created attachment 442769 [details] Patch
Anders Carlsson
Comment 3 2021-10-28 19:27:35 PDT
Comment on attachment 442769 [details] Patch I have to say I'm a little sad I didn't get to pull the plug(-ins), but at least I can r=me doing so.
Alex Christensen
Comment 4 2021-10-28 20:44:15 PDT
Created attachment 442777 [details] Patch
Alex Christensen
Comment 5 2021-10-28 22:44:56 PDT
iOS needs a clean build after this change.
Yusuke Suzuki
Comment 6 2021-10-29 00:39:00 PDT
I'm pretty happy that we can remove NPAPI support!!! Now, super hacky RuntimeArray thing (runtime_array.cpp) is only used by Objective-C bridge.
Alex Christensen
Comment 7 2021-10-29 13:33:34 PDT
r285047
Brent Fulgham
Comment 8 2021-10-29 14:09:33 PDT
I love this patch so much!
Alex Christensen
Comment 9 2021-10-29 14:11:11 PDT
r285051
Alex Christensen
Comment 10 2021-10-29 14:15:54 PDT
r285052
Alex Christensen
Comment 11 2021-10-29 15:21:32 PDT
r285058
Alex Christensen
Comment 12 2021-10-29 16:06:38 PDT
Internal commit 2e4c44c95333771d6b86b5ac3f93cc5edb845ac2 was also necessary to fix the internal build.
Brent Fulgham
Comment 13 2021-11-12 10:18:43 PST
<rdar://problem/84566739>
Note You need to log in before you can comment on or make changes to this bug.