Summary: | Multiple build issues with ENABLE_VIDEO=OFF | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrian Perez <aperez> | ||||||||
Component: | Tools / Tests | Assignee: | Adrian Perez <aperez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | 2khramtsov, aboxhall, andresg_22, annulen, apinheiro, bst, cfleizach, cgarcia, clopez, dmazzoni, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, psaavedra, ryuan.choi, samuel_white, sergio, sl1pkn07, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Local Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=217991 | ||||||||||
Attachments: |
|
Description
Adrian Perez
2021-10-25 13:43:36 PDT
Created attachment 442408 [details]
Patch
Created attachment 442415 [details]
Patch
*** Bug 232199 has been marked as a duplicate of this bug. *** *** Bug 218042 has been marked as a duplicate of this bug. *** Comment on attachment 442415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442415&action=review > Source/WebCore/ChangeLog:3 > + [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF This is not specific to WPE/GTK, all the changes are in cross-platform code. (In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 442415 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442415&action=review > > > Source/WebCore/ChangeLog:3 > > + [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF > > This is not specific to WPE/GTK, all the changes are in cross-platform code. Right. At first I thought this was WPE/GTK specific, when filing the bug. I'll change the title before landing 👍️ Created attachment 442468 [details]
Patch for landing
Committed r284858 (243535@main): <https://commits.webkit.org/243535@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442468 [details]. seems still occour in 2.34.3. see https://bugs.webkit.org/show_bug.cgi?id=232394#c4 greetings |