Bug 232264

Summary: Multiple build issues with ENABLE_VIDEO=OFF
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: 2khramtsov, aboxhall, andresg_22, annulen, apinheiro, bst, cfleizach, cgarcia, clopez, dmazzoni, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, psaavedra, ryuan.choi, samuel_white, sergio, sl1pkn07, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217991
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Adrian Perez
Reported 2021-10-25 13:43:36 PDT
In particular, at least AXObjectCache.cpp and BifurcatedGraphicsContext.cpp are using HTMLMediaElement without guarding their usage with ENABLE(VIDEO). The issue on the latter affects also the 2.34.x releases. Also, the recently landed support for media session (see bug #217991) needs to be gated on ENABLE_VIDEO.
Attachments
Patch (3.73 KB, patch)
2021-10-25 13:48 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch (8.78 KB, patch)
2021-10-25 14:15 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.74 KB, patch)
2021-10-26 00:05 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2021-10-25 13:48:02 PDT
Created attachment 442408 [details] Patch
Adrian Perez
Comment 2 2021-10-25 14:15:59 PDT
Created attachment 442415 [details] Patch
Adrian Perez
Comment 3 2021-10-25 14:24:31 PDT
*** Bug 232199 has been marked as a duplicate of this bug. ***
Adrian Perez
Comment 4 2021-10-25 14:29:20 PDT
*** Bug 218042 has been marked as a duplicate of this bug. ***
Carlos Garcia Campos
Comment 5 2021-10-25 22:53:35 PDT
Comment on attachment 442415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442415&action=review > Source/WebCore/ChangeLog:3 > + [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF This is not specific to WPE/GTK, all the changes are in cross-platform code.
Adrian Perez
Comment 6 2021-10-25 23:55:27 PDT
(In reply to Carlos Garcia Campos from comment #5) > Comment on attachment 442415 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442415&action=review > > > Source/WebCore/ChangeLog:3 > > + [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF > > This is not specific to WPE/GTK, all the changes are in cross-platform code. Right. At first I thought this was WPE/GTK specific, when filing the bug. I'll change the title before landing 👍️
Adrian Perez
Comment 7 2021-10-26 00:05:05 PDT
Created attachment 442468 [details] Patch for landing
EWS
Comment 8 2021-10-26 00:36:17 PDT
Committed r284858 (243535@main): <https://commits.webkit.org/243535@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442468 [details].
Radar WebKit Bug Importer
Comment 9 2021-10-26 00:37:18 PDT
<rdar://problem/84651607>
sL1pKn07
Comment 10 2022-01-18 17:15:08 PST
seems still occour in 2.34.3. see https://bugs.webkit.org/show_bug.cgi?id=232394#c4 greetings
Note You need to log in before you can comment on or make changes to this bug.