Bug 232264

Summary: Multiple build issues with ENABLE_VIDEO=OFF
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: 2khramtsov, aboxhall, andresg_22, annulen, apinheiro, bst, cfleizach, cgarcia, clopez, dmazzoni, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, psaavedra, ryuan.choi, samuel_white, sergio, sl1pkn07, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217991
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Adrian Perez 2021-10-25 13:43:36 PDT
In particular, at least AXObjectCache.cpp and BifurcatedGraphicsContext.cpp
are using HTMLMediaElement without guarding their usage with ENABLE(VIDEO).
The issue on the latter affects also the 2.34.x releases.

Also, the recently landed support for media session (see bug #217991) needs
to be gated on ENABLE_VIDEO.
Comment 1 Adrian Perez 2021-10-25 13:48:02 PDT
Created attachment 442408 [details]
Patch
Comment 2 Adrian Perez 2021-10-25 14:15:59 PDT
Created attachment 442415 [details]
Patch
Comment 3 Adrian Perez 2021-10-25 14:24:31 PDT
*** Bug 232199 has been marked as a duplicate of this bug. ***
Comment 4 Adrian Perez 2021-10-25 14:29:20 PDT
*** Bug 218042 has been marked as a duplicate of this bug. ***
Comment 5 Carlos Garcia Campos 2021-10-25 22:53:35 PDT
Comment on attachment 442415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442415&action=review

> Source/WebCore/ChangeLog:3
> +        [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF

This is not specific to WPE/GTK, all the changes are in cross-platform code.
Comment 6 Adrian Perez 2021-10-25 23:55:27 PDT
(In reply to Carlos Garcia Campos from comment #5)
> Comment on attachment 442415 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442415&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [WPE][GTK] Multiple build issues with ENABLE_VIDEO=OFF
> 
> This is not specific to WPE/GTK, all the changes are in cross-platform code.

Right. At first I thought this was WPE/GTK specific, when filing the bug.
I'll change the title before landing 👍️
Comment 7 Adrian Perez 2021-10-26 00:05:05 PDT
Created attachment 442468 [details]
Patch for landing
Comment 8 EWS 2021-10-26 00:36:17 PDT
Committed r284858 (243535@main): <https://commits.webkit.org/243535@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442468 [details].
Comment 9 Radar WebKit Bug Importer 2021-10-26 00:37:18 PDT
<rdar://problem/84651607>
Comment 10 sL1pKn07 2022-01-18 17:15:08 PST
seems still occour in 2.34.3. see https://bugs.webkit.org/show_bug.cgi?id=232394#c4

greetings