Bug 232228

Summary: [WPE][Qt] Do not use WebKit internals in the implementation
Product: WebKit Reporter: Adrian Perez <aperez>
Component: WebKit APIAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cgarcia, clopez, ews-watchlist, gyuyoung.kim, mcatanzaro, pnormand, psaavedra, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Adrian Perez
Reported 2021-10-25 02:12:19 PDT
Currently the WPE Qt implementation still has a few uses of GRefPtr and GUniquePtr. These are only a handful, and could be easily removed. Doing this would allow packagers to split building of the Qt API away from the rest of a WPE port build, in its own package, without needing to rebuild all WebKit for something that is essentially a layer which build on top of the public WPE port API.
Attachments
Patch (10.49 KB, patch)
2021-10-28 06:46 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Patch (10.46 KB, patch)
2021-10-28 12:20 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2021-10-28 06:46:44 PDT
Created attachment 442702 [details] Patch
Adrian Perez
Comment 2 2021-10-28 12:20:22 PDT
Created attachment 442729 [details] Patch Same patch as before, rebased after the fix for bug #232435 got landed
Michael Catanzaro
Comment 3 2021-10-28 12:38:37 PDT
All looks good to me. I assume Phil will want to review it, though.
Adrian Perez
Comment 4 2021-10-28 13:33:58 PDT
(In reply to Michael Catanzaro from comment #3) > All looks good to me. I assume Phil will want to review it, though. I had discussed with Philippe the possibility of making this patch before submitting it, so I was indeed waiting for his review :) Thanks to you both!
EWS
Comment 5 2021-10-28 13:58:06 PDT
Committed r285000 (243646@main): <https://commits.webkit.org/243646@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442729 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-28 13:59:18 PDT
<rdar://problem/84776484>
Note You need to log in before you can comment on or make changes to this bug.