Bug 231895

Summary:

AX: Unify speech synthesizer platform usage for Mac/iOS

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andresg_22, ayumi_kojima, benjamin, cdumez, cmarcelo, ews-watchlist, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=234105

Attachments:

Description	Flags
patch	none
patch	andresg_22: review+, ews-feeder: commit-queue-
patch	none
patch	none
patch for landing	none
patch for landing	none
patch	none
patch	ews-feeder: commit-queue-
patch	none
patch	ews-feeder: commit-queue-
patch	none

chris fleizach

Reported 2021-10-18 08:40:36 PDT

Unify the platform speech synthesizer usage for macOS. Now that AVSpeechSynthesizer has been fully supported for a number of years, we can switch over

Attachments
patch (33.08 KB, patch) 2021-10-18 08:42 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (33.16 KB, patch) 2021-10-18 08:49 PDT, chris fleizach	andresg_22: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (35.29 KB, patch) 2021-10-20 08:22 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (35.29 KB, patch) 2021-10-20 19:43 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch for landing (35.29 KB, patch) 2021-10-21 09:06 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch for landing (35.29 KB, patch) 2021-10-21 09:07 PDT, chris fleizach	no flags	Details Formatted Diff Diff
patch (50.19 KB, patch) 2021-11-27 13:37 PST, chris fleizach	no flags	Details Formatted Diff Diff
patch (48.46 KB, patch) 2021-11-27 13:40 PST, chris fleizach	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (49.41 KB, patch) 2021-11-27 16:32 PST, chris fleizach	no flags	Details Formatted Diff Diff
patch (49.59 KB, patch) 2021-11-27 16:33 PST, chris fleizach	ews-feeder: commit-queue-	Details Formatted Diff Diff
patch (49.85 KB, patch) 2021-11-27 22:43 PST, chris fleizach	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-10-18 08:40:47 PDT

<rdar://problem/84372479>

chris fleizach

Comment 2 2021-10-18 08:42:19 PDT

Created attachment 441606 [details] patch

chris fleizach

Comment 3 2021-10-18 08:49:40 PDT

Created attachment 441607 [details] patch

Andres Gonzalez

Comment 4 2021-10-18 09:09:15 PDT

(In reply to chris fleizach from comment #3) > Created attachment 441607 [details] > patch --- a/Source/WebCore/SourcesCocoa.txt +++ a/Source/WebCore/SourcesCocoa.txt @@ -255,6 +255,7 @@ platform/cocoa/ParentalControlsContentFilter.mm platform/cocoa/PasteboardCocoa.mm platform/cocoa/PasteboardCustomDataCocoa.mm platform/cocoa/PlatformPasteboardCocoa.mm +platform/cocoa/PlatformSpeechSynthesizerIOS.mm @no-unify Shouldn't this file be renamed to *Cocoa.mm now that is for both Mac and iOS?

chris fleizach

Comment 5 2021-10-20 08:22:32 PDT

Created attachment 441881 [details] patch

chris fleizach

Comment 6 2021-10-20 19:43:29 PDT

Created attachment 441975 [details] patch

chris fleizach

Comment 7 2021-10-21 09:06:15 PDT

Created attachment 442037 [details] patch for landing

chris fleizach

Comment 8 2021-10-21 09:07:02 PDT

Created attachment 442038 [details] patch for landing

EWS

Comment 9 2021-10-23 00:46:40 PDT

Committed r284742 (243451@main): <https://commits.webkit.org/243451@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442038 [details].

ayumi_kojima

Comment 10 2021-10-25 14:32:14 PDT

Reverted r284742 for reason: Reverting because this commit may have casued a regression on imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-events.html Committed r284822 (243514@main): <https://commits.webkit.org/243514@main>

chris fleizach

Comment 11 2021-11-27 13:37:19 PST

Created attachment 445221 [details] patch

chris fleizach

Comment 12 2021-11-27 13:40:01 PST

Created attachment 445222 [details] patch

chris fleizach

Comment 13 2021-11-27 16:32:05 PST

Created attachment 445226 [details] patch

chris fleizach

Comment 14 2021-11-27 16:33:56 PST

Created attachment 445227 [details] patch