| Summary: | All the SDKVariant.xcconfig files should match | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | WebRTC | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, ap, cdumez, dino, eric.carlson, ews-watchlist, hi, jbedard, kbr, keith_miller, kondapallykalyan, mark.lam, msaboff, pangle, rniwa, saam, tzagallo, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2021-10-13 01:54:16 PDT
Created attachment 441045 [details]
Patch
Created attachment 441176 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Comment on attachment 441176 [details] Patch LGTM View in context: https://bugs.webkit.org/attachment.cgi?id=441176&action=review > Source/JavaScriptCore/ChangeLog:8 > + The linter says they're all supposed to match. I do not see the style checker being red in the patch the changes were added (https://bugs.webkit.org/show_bug.cgi?id=225505). Was the style checker updated after the changes were done? Comment on attachment 441176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441176&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + The linter says they're all supposed to match. > > I do not see the style checker being red in the patch the changes were added (https://bugs.webkit.org/show_bug.cgi?id=225505). > Was the style checker updated after the changes were done? Looks like the style check was added in https://trac.webkit.org/changeset/240176/webkit and the libwebrtc changes were added in https://trac.webkit.org/changeset/277176/webkit Committed r284193 (243007@main): <https://commits.webkit.org/243007@main> |