Bug 231663

Summary: All the SDKVariant.xcconfig files should match
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: WebRTCAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, cdumez, dino, eric.carlson, ews-watchlist, hi, jbedard, kbr, keith_miller, kondapallykalyan, mark.lam, msaboff, pangle, rniwa, saam, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch youennf: review+, ews-feeder: commit-queue-

Myles C. Maxfield
Reported 2021-10-13 01:54:16 PDT
All the SDKVariant.xcconfig files should match
Attachments
Patch (1.63 KB, patch)
2021-10-13 01:54 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (26.19 KB, patch)
2021-10-13 19:05 PDT, Myles C. Maxfield 		youennf: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-10-13 01:54:43 PDT
Created attachment 441045 [details] Patch
Myles C. Maxfield
Comment 2 2021-10-13 19:05:58 PDT
Created attachment 441176 [details] Patch
EWS Watchlist
Comment 3 2021-10-13 19:07:06 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
youenn fablet
Comment 4 2021-10-13 23:16:23 PDT
Comment on attachment 441176 [details] Patch LGTM View in context: https://bugs.webkit.org/attachment.cgi?id=441176&action=review > Source/JavaScriptCore/ChangeLog:8 > + The linter says they're all supposed to match. I do not see the style checker being red in the patch the changes were added (https://bugs.webkit.org/show_bug.cgi?id=225505). Was the style checker updated after the changes were done?
Myles C. Maxfield
Comment 5 2021-10-14 13:26:35 PDT
Comment on attachment 441176 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441176&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + The linter says they're all supposed to match. > > I do not see the style checker being red in the patch the changes were added (https://bugs.webkit.org/show_bug.cgi?id=225505). > Was the style checker updated after the changes were done? Looks like the style check was added in https://trac.webkit.org/changeset/240176/webkit and the libwebrtc changes were added in https://trac.webkit.org/changeset/277176/webkit
Myles C. Maxfield
Comment 6 2021-10-14 13:30:23 PDT
Committed r284193 (243007@main): <https://commits.webkit.org/243007@main>
Radar WebKit Bug Importer
Comment 7 2021-10-14 13:31:16 PDT
<rdar://problem/84271698>
Note You need to log in before you can comment on or make changes to this bug.