Bug 225505 - Allow libwebrtc to build for Mac Catalyst
Summary: Allow libwebrtc to build for Mac Catalyst
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-06 22:54 PDT by Alex Christensen
Modified: 2021-05-07 09:22 PDT (History)
7 users (show)

See Also:

Attachments
Patch (21.41 KB, patch)
2021-05-06 23:00 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (27.71 KB, patch)
2021-05-07 08:36 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-05-06 22:54:42 PDT 
Allow libwebrtc to build for Mac Catalyst
Comment 1 Alex Christensen 2021-05-06 23:00:19 PDT 
Created attachment 427973 [details]
Patch
Comment 2 youenn fablet 2021-05-07 05:27:15 PDT 
Comment on attachment 427973 [details]
Patch

Nice!

View in context: https://bugs.webkit.org/attachment.cgi?id=427973&action=review

> Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp8_rtcd.h:658
> +#ifndef WK_MAC_CATALYST

Hum, maybe I should change WEBRTC_WEBKIT_BUILD to WK_BUILD?
Or maybe we should change here to WEBRTC_WEBKIT_MAC_CATALIST

> Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp9_rtcd.h:518
> +#if !defined(WK_DISABLE_HARDWARE_ACCELERATION) && !defined(WK_MAC_CATALYST)

And change to WEBRTC_WEBKIT_DISABLE_HARDWARE_ACCELERATION
Comment 3 Alex Christensen 2021-05-07 08:36:33 PDT 
Created attachment 427999 [details]
Patch
Comment 4 Alex Christensen 2021-05-07 09:22:02 PDT 
r277176